Consolidate network attribute extraction into DbClientAttributesGetter #15149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
github-actions
bot
added
the
test native
trask
force-pushed
the
db-networking-attributes
branch
2 times, most recently
from
3b79cd1 to
d2988b1
Compare
trask
force-pushed
the
db-networking-attributes
branch
from
d2988b1 to
a6bef40
Compare
trask
commented
Oct 27, 2025
Comment on lines
+46
to
+53
| public String getServerAddress(VertxSqlClientRequest request) { | ||
| return request.getHost(); | ||
| } | ||
|
|
||
| @Nullable | ||
| public String getConnectionString(VertxSqlClientRequest request) { | ||
| return null; | ||
| @Override | ||
| public Integer getServerPort(VertxSqlClientRequest request) { | ||
| return request.getPort(); |
There was a problem hiding this comment.
shouldn't there be corresponding new test assertions?
...main/java/io/opentelemetry/instrumentation/r2dbc/v1_0/internal/R2dbcInstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
.../javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jdbc/JdbcSingletons.java
Outdated
Show resolved
Hide resolved
trask
commented
Oct 28, 2025
Comment on lines
36
to
47
|
|
||
| @Deprecated | ||
| @Nullable | ||
| @Override | ||
| public String getServerAddress(CassandraRequest request) { | ||
| return null; | ||
| } | ||
|
|
||
| @Nullable | ||
| public String getConnectionString(CassandraRequest request) { | ||
| @Override | ||
| public Integer getServerPort(CassandraRequest request) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
why implement getServerAddress and getServerPort when getNetworkPeerInetSocketAddress is implemented below?
Comment on lines
42
to
50
| public String getServerAddress(CassandraRequest request) { | ||
| return null; | ||
| } | ||
|
|
||
| @Nullable | ||
| public String getConnectionString(CassandraRequest request) { | ||
| @Override | ||
| public Integer getServerPort(CassandraRequest request) { | ||
| return null; | ||
| } |
Comment on lines
40
to
51
|
|
||
| @Deprecated | ||
| @Nullable | ||
| @Override | ||
| public String getServerAddress(CassandraRequest request) { | ||
| return null; | ||
| } | ||
|
|
||
| @Nullable | ||
| public String getConnectionString(CassandraRequest request) { | ||
| @Override | ||
| public Integer getServerPort(CassandraRequest request) { | ||
| return null; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently built on top of #15139