Fix most tests on Windows #15153
Merged
Fix most tests on Windows #15153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Oct 27, 2025
...est/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceAsyncClientTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceSyncClientTest.java
Outdated
Show resolved
Hide resolved
...est/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/client/Netty38ClientTest.java
Outdated
Show resolved
Hide resolved
...ava/io/opentelemetry/javaagent/instrumentation/powerjob/v4_0/PowerJobBasicProcessorTest.java
Outdated
Show resolved
Hide resolved
...main/java/io/opentelemetry/instrumentation/ratpack/client/AbstractRatpackHttpClientTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/io/opentelemetry/instrumentation/ratpack/v1_7/AbstractRatpackHttpClientTest.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/javaagent/instrumentation/reactornetty/v0_9/ReactorNettyHttpClientTest.java
Outdated
Show resolved
Hide resolved
trask
commented
Oct 27, 2025
.../io/opentelemetry/javaagent/instrumentation/akkahttp/AkkaHttpClientInstrumentationTest.scala
Outdated
Show resolved
Hide resolved
...lemetry/javaagent/instrumentation/reactornetty/v1_0/ReactorNettyHttpClientUsingFromTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8/JarDetails.java
Outdated
Show resolved
Hide resolved
...st/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8/JarAnalyzerTest.java
Outdated
Show resolved
Hide resolved
...agent-bootstrap/src/test/java/io/opentelemetry/javaagent/bootstrap/AgentClassLoaderTest.java
Outdated
Show resolved
Hide resolved
...entelemetry/javaagent/tooling/instrumentation/indy/InstrumentationModuleClassLoaderTest.java
Outdated
Show resolved
Hide resolved
...entelemetry/javaagent/tooling/instrumentation/indy/InstrumentationModuleClassLoaderTest.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/io/opentelemetry/spring/smoketest/AbstractOtelSpringStarterSmokeTest.java
Outdated
Show resolved
Hide resolved
trask
added a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 27, 2025
Disable connection error tests (unopened port and non-routable address) on Windows due to different exception handling in Netty. Windows wraps connection exceptions in AbstractChannel$AnnotatedConnectException with different messages, causing test assertion failures even with existing exception unwrapping logic. Fixes open-telemetry#15153
Merged
trask
commented
Oct 27, 2025
...ava/io/opentelemetry/javaagent/instrumentation/powerjob/v4_0/PowerJobBasicProcessorTest.java
Outdated
Show resolved
Hide resolved
...ava/io/opentelemetry/javaagent/instrumentation/powerjob/v4_0/PowerJobBasicProcessorTest.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/javaagent/instrumentation/reactornetty/v0_9/ReactorNettyHttpClientTest.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/javaagent/instrumentation/reactornetty/v1_0/ReactorNettyHttpClientTest.java
Outdated
Show resolved
Hide resolved
trask
force-pushed
the
windows
branch
3 times, most recently
from
44a9245 to
2a84bcb
Compare
trask
force-pushed
the
windows
branch
2 times, most recently
from
a5030ab to
5e9a6ee
Compare
jaydeluca
approved these changes
Nov 4, 2025
...io/opentelemetry/javaagent/instrumentation/reactornetty/v0_9/ReactorNettyHttpClientTest.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/javaagent/instrumentation/reactornetty/v1_0/ReactorNettyHttpClientTest.java
Outdated
Show resolved
Hide resolved
…ent/src/test/java/io/opentelemetry/javaagent/instrumentation/reactornetty/v0_9/ReactorNettyHttpClientTest.java Co-authored-by: Jay DeLuca <jaydeluca4@gmail.com>
laurit
reviewed
Nov 5, 2025
| } | ||
|
|
||
| // Windows holds open handles to jars loaded through URLClassLoader even after the loader is | ||
| // closed, which keeps the temp directory locked and causes test cleanup to fail. |
Contributor
There was a problem hiding this comment.
Probably because of the jar file cache that the url connection uses. If that is the case then https://docs.oracle.com/javase/8/docs/api/java/net/URLConnection.html#setDefaultUseCaches-boolean- might help.
laurit
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think ratpack tests are the only ones remaining