WIP: Use ruff #34
Closed
WIP: Use ruff #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekelgindy
requested changes
Jan 30, 2024
Collaborator
tarekelgindy
left a comment
tarekelgindy
left a comment
There was a problem hiding this comment.
Additional point, should we include explicit instructions for how to run ruff manually? I've seen implementations that use a Makefile to allow ruff to be run, but wasn't sure what the best approach was. This might be related to running this in the github actions.
josephmckinsey
force-pushed
the
jm/ruff
branch
from
0cacd02 to
32cbcde
Compare
Collaborator
|
Collaborator
|
@josephmckinsey why not set up a pre-commit config instead? |
Merged
Collaborator
Author
|
Closed in favor of #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #32.