[PHEE-999] Changed kafka port from 9092 to 9099#420
Open
abhinavm117 wants to merge 1 commit intoopenMF:masterfrom
Open
[PHEE-999] Changed kafka port from 9092 to 9099#420abhinavm117 wants to merge 1 commit intoopenMF:masterfrom
abhinavm117 wants to merge 1 commit intoopenMF:masterfrom
Conversation
Contributor
|
@abhinavm117 : Instead of making a pull request and then doing dev testing using CI, do the opposite. Test the case in isolation (local or cloud), and if it's working, then submit a PR. Often the reason why it can't be tested in cloud before submitting a draft PR to test via ephemeral CircleCI instance is flimsy so please continuously evaluate your arguments and submit your arguments in written format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[].Format:
[jira_ticket] descriptionex: [phee-123] PR title.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Followed the PR title naming convention mentioned above.
Design related bullet points or design document link related to this PR added in the description above.
Updated corresponding Postman Collection or Api documentation for the changes in this PR.
Created/updated unit or integration tests for verifying the changes made.
Added required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing