SND-675 this changes allows turn on and off TLS connection with connector-bulk. #437
Open
oleksiidn wants to merge 1 commit intoopenMF:masterfrom
Open
Conversation
Reason is next. GovStack is adapting Mifos. GovStack sandbox design for demo purpose. Implementing internal TLS connection between building blocks isn't necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changes allows turn on and off TLS connection with connector-bulk.
Reason is next. GovStack is adapting Mifos. GovStack sandbox design for demo purpose. Implementing internal TLS connection between building blocks isn't necessary.
Application properties that would be possible to configure from helm chart.
Changes allow to avoid create a bulk-processor secret step of deployment.
https://govstack-global.atlassian.net/browse/SND-675
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Followed the PR title naming convention mentioned above.
Design related bullet points or design document link related to this PR added in the description above.
Updated corresponding Postman Collection or Api documentation for the changes in this PR.
Created/updated unit or integration tests for verifying the changes made.
Added required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing