[GOV-570] New Batch and Voucher creation views#80
Conversation
alberto-art3ch
force-pushed
the
views/paymenthub_004
branch
from
1928d96 to
369163f
Compare
alberto-art3ch
force-pushed
the
views/paymenthub_004
branch
from
369163f to
9be5c84
Compare
|
@alberto-art3ch , If you can send the PR title in this format: the CIRCLE CI will build this and push image to docker hub. |
| @@ -1,33 +1,36 @@ | |||
| PH_OPS_BACKEND_SERVER_URL=https://paymenthub.qa.oneacrefund.org/opsapp/api/v1 | |||
| export PH_OPS_BATCH_SIGNATURE=12345677899 | |||
There was a problem hiding this comment.
Signature is dynamic so cannot be set in the env variable.
There was a problem hiding this comment.
Done! removed
| @@ -1,33 +1,36 @@ | |||
| PH_OPS_BACKEND_SERVER_URL=https://paymenthub.qa.oneacrefund.org/opsapp/api/v1 | |||
| export PH_OPS_BATCH_SIGNATURE=12345677899 | |||
| export PH_OPS_BULK_CONNECTOR_URL=https://paymenthub.qa.oneacrefund.org | |||
There was a problem hiding this comment.
Please add these environment variables to as well: https://github.com/openMF/ph-ee-env-template/blob/master/helm/ph-ee-engine/operations-web/templates/deployment.yaml
There was a problem hiding this comment.
Done! I've created a PR for that openMF/ph-ee-env-template#404
| }); | ||
| } else { | ||
| console.log("Not Implemented " + environment.oauth.type); | ||
| console.log('Not Implemented ' + environment.oauth.type); |
There was a problem hiding this comment.
let's remove logs that are added for debug while development
| signatureBatchKey: window['env']['signatureBatchKey'] || '', | ||
| bulkConnectorOps: window['env']['bulkConnectorOps'] || 'https://bulk-connector-demo.sandbox.fynarfin.io', | ||
| vouchers: window['env']['serverApiUrlVou'] || 'https://paymenthub.qa.oneacrefund.org/opsapp/api/v1', | ||
| voucherCallbackUrl: window['env']['callbackUrlVou'] || 'https://webhook.site/', |
There was a problem hiding this comment.
Please make the callback URLs configurable from backend
alberto-art3ch
changed the title
Done! |
2 participants
Description
GOV-570 Create Voucher Screen, New Batch and Voucher creation views
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Followed the PR title naming convention mentioned above.
Design related bullet points or design document link related to this PR added in the description above.
Updated corresponding Postman Collection or Api documentation for the changes in this PR.
Create/update unit or integration tests for verifying the changes made.
Add required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing