ignore the destinationText of a leg until this is correctly returned … #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from backend and use ids for stopPoints instead of text
r3to
approved these changes
Dec 15, 2025
Sources/OJP/Models/OJPv2+Trip.swift
Outdated
| h.combine(timedLeg.service.publishedServiceName.text) | ||
| h.combine(timedLeg.service.destinationText?.text) | ||
| h.combine(timedLeg.legBoard.stopPointName.text) | ||
| //h.combine(timedLeg.service.destinationText?.text) // ignore this until this bug is fixed: https://github.com/openTdataCH/ojp-sdk/issues/198 |
Contributor
There was a problem hiding this comment.
Kann man wohl komplett rausnehmen, wenn stopPointRef berücksichtigt
Contributor
Author
There was a problem hiding this comment.
Aber destination text ist die finale Destination des Zuges, hingegen die stopPoints sind Abfahrt und Ankunft von deine gefahrene Strecke.
Contributor
Author
There was a problem hiding this comment.
Oder meinst du man könnte nutzen destinationStopPointRef ?
Contributor
There was a problem hiding this comment.
Ja, sorry, habe da was durcheinandergebracht...
Die destinationStopPointRef scheint sich ja nicht zu ändern (im letzten Screenshot von deinem diff im Issue) und könnte permanent anstelle von destinationText verwendet werden.
Contributor
Author
There was a problem hiding this comment.
Ah ja super idee! done :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logic for fetching the next trip is not working correctly because the backend doesn't provide a consistent "destinationText" (this bug is still open openTdataCH/ojp-sdk#198).
In the meantime we can fix this in the SDK and ignore the destinationText from the hash.
Also in order to have more robustness I think that is better to use the ids instead of the name for the leg stations.