Skip to content

Conversation

@GromNaN
Copy link
Collaborator

@GromNaN GromNaN commented Sep 4, 2025

What:

  • Bug Fix
  • New Feature

Description:

  • Add configuration for project and base_uri.
  • Convert the bundle to a single bundle class
  • Remove compatibility with unsupported Symfony versions. Keep only 6.4 and 7.3
  • Add support for Symfony 8.0

Related:

@GromNaN GromNaN force-pushed the single-file branch 6 times, most recently from 8104b98 to 98853d6 Compare September 5, 2025 08:17
@GromNaN GromNaN requested a review from Copilot September 5, 2025 08:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the OpenAI Symfony bundle from a traditional bundle structure to a single-class bundle using Symfony's AbstractBundle. It removes support for older Symfony versions (5.4, 6.3) and adds support for Symfony 8.0, while introducing additional configuration options for project and base_uri.

Key changes:

  • Consolidates bundle functionality into a single OpenAIBundle class extending AbstractBundle
  • Adds project and base_uri configuration options
  • Updates Symfony version constraints to support only 6.4, 7.3+, and 8.0

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/OpenAIBundle.php Refactored to extend AbstractBundle with embedded configuration and service registration
tests/OpenAIBundleTest.php New integration test using Symfony kernel to test the complete bundle
src/DependencyInjection/OpenAIExtension.php Removed - functionality moved to OpenAIBundle
src/DependencyInjection/Configuration.php Removed - configuration moved to OpenAIBundle
src/Resources/config/services.php Removed - service configuration moved to OpenAIBundle
tests/DependencyInjection/OpenAIExtensionTest.php Removed - replaced by integration test
composer.json Updated Symfony version constraints and dev dependencies
.github/workflows/tests.yml Updated CI matrix to test only supported Symfony versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@GromNaN GromNaN requested a review from nunomaduro September 5, 2025 08:22
@GromNaN GromNaN merged commit cc47eb6 into openai-php:main Oct 2, 2025
9 checks passed
@GromNaN GromNaN deleted the single-file branch October 2, 2025 13:32
@GromNaN GromNaN mentioned this pull request Oct 15, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant