Delete leftover unused files #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes custom pagination implementation files for VectorStores, Responses, and Batch resources, replacing them with auto-generated pagination code. The custom implementation is no longer needed as pagination is now handled by the code generation pipeline.
Key Changes:
- Removed custom pagination page tokens and collection results for VectorStores, VectorStoreFiles, VectorStoreFileBatches
- Removed custom pagination page tokens and collection results for ResponseItems
- Removed custom pagination page tokens and collection results for Batches
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| VectorStoreFileCollectionPageToken.cs | Deleted custom page token implementation for vector store files |
| VectorStoreFileBatchCollectionPageToken.cs | Deleted custom page token implementation for vector store file batches |
| VectorStoreCollectionResult.cs | Deleted custom collection result implementation for vector stores |
| VectorStoreCollectionPageToken.cs | Deleted custom page token implementation for vector stores |
| AsyncVectorStoreCollectionResult.cs | Deleted custom async collection result implementation for vector stores |
| ResponseItemCollectionOrder.cs | Deleted custom collection order type (now generated) |
| ResponseItemCollectionOptions.cs | Deleted custom collection options type (now generated) |
| ResponseItemCollectionResult.cs | Deleted custom collection result implementation for response items |
| ResponseItemCollectionPageToken.cs | Deleted custom page token implementation for response items |
| AsyncResponseItemCollectionResult.cs | Deleted custom async collection result implementation for response items |
| BatchCollectionResult.cs | Deleted custom collection result implementation for batches |
| BatchCollectionPageToken.cs | Deleted custom page token implementation for batches |
| AsyncBatchCollectionResult.cs | Deleted custom async collection result implementation for batches |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
christothes
approved these changes
Oct 29, 2025
jsquire
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.