Skip to content

Remove unused primary/secondary path parsing in detail view #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshkenny-oai merged 1 commit into from
Jan 5, 2026
+0 −26
Merged

Remove unused primary/secondary path parsing in detail view #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions snapo-app-mac/Snap-O/NetworkInspector/NetworkInspectorStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,8 +825,6 @@ struct NetworkInspectorWebSocketViewModel: Identifiable {
let timing: InspectorTiming
let requestHeaders: [NetworkInspectorRequestViewModel.Header]
let responseHeaders: [NetworkInspectorRequestViewModel.Header]
let primaryPathComponent: String
let secondaryPath: String
let willOpen: SnapONetWebSocketWillOpenRecord?
let opened: SnapONetWebSocketOpenedRecord?
let closing: SnapONetWebSocketClosingRecord?
Expand Down Expand Up @@ -894,30 +892,6 @@ struct NetworkInspectorWebSocketViewModel: Identifiable {
wallClockBase: server?.wallClockBase
)

let components = URLComponents(string: urlString)
if let path = components?.path, !path.isEmpty {
let parts = path.split(separator: "/", omittingEmptySubsequences: true)
primaryPathComponent = parts.last.map(String.init) ?? path
let remaining = parts.dropLast()
if remaining.isEmpty {
secondaryPath = components?.percentEncodedQuery.map { "?\($0)" } ?? "\n"
} else {
let base = "/" + remaining.joined(separator: "/")
if let query = components?.percentEncodedQuery, !query.isEmpty {
secondaryPath = base + "?" + query
} else {
secondaryPath = base
}
}
} else {
primaryPathComponent = components?.host ?? session.socketID
if let query = components?.percentEncodedQuery, !query.isEmpty {
secondaryPath = "?\(query)"
} else {
secondaryPath = ""
}
}

requestHeaders = session.willOpen?.headers.map { NetworkInspectorRequestViewModel.Header(name: $0.name, value: $0.value) } ?? []

responseHeaders = session.opened?.headers.map { NetworkInspectorRequestViewModel.Header(name: $0.name, value: $0.value) } ?? []
Expand Down