-
Notifications
You must be signed in to change notification settings - Fork 2
fix: image build #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @pat-s |
|
I did a standard The fixes above were needed to get a build going in the first place (for the build stage). It would be easier to spot/reference if there would be an open build process for all the images, regardless of whether they are being stored in your own registry or on dockerhub and friends 🙂️ (PS: just as a side-note to all the image building approaches: most openanalytic images are quite out-of-date WRT to the base images and other deps. And include a lot of things which are not needed to get the app running. Example: in the repo I linked, I built |
| app.use(pinia) | ||
| app.use(i18nInstance) | ||
| app.use(abilitiesPlugin, caslAbility) | ||
| app.component('apexchart', VueApexCharts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are using Vue 3 (and vue3-apexcharts), the recommended way to register is app.use(VueApexCharts) (see https://apexcharts.com/docs/vue-charts/)
| "useDefineForClassFields": true, | ||
| "module": "ESNext", | ||
| "moduleResolution": "Node", | ||
| "moduleResolution": "bundler", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, in this case also "allowImportingTsExtensions": true should be used. See https://vite.dev/guide/performance.html#reduce-resolve-operations.
Ok, thanks for the quick reply. |
These patches are required to get the Dockerfile built (with
node:lts-alpine).See also:
Would like to switch back to the upstream source again, once fixed.