OBPIH-6952 Add test for asserting receiving bin location is created#45
Merged
awalkowiak merged 5 commits intomainfrom Feb 11, 2025
Merged
OBPIH-6952 Add test for asserting receiving bin location is created#45awalkowiak merged 5 commits intomainfrom
awalkowiak merged 5 commits intomainfrom
Conversation
kkrawczyk123
force-pushed
the
OBPIH-6952
branch
from
82becb7 to
63fa1d8
Compare
awalkowiak
requested changes
Feb 4, 2025
| }); | ||
|
|
||
| await test.step('Assert Bin location is not created yet', async () => { | ||
| const receivingBin = 'R-' + STOCK_MOVEMENT.identifier; |
Contributor
There was a problem hiding this comment.
I think it would be worth to move R- to a global const or even an environment variable, because this is configurable, and once changed on the OB system config, you'd need to update it everywhere.
Contributor
There was a problem hiding this comment.
@kkrawczyk123 I think you can add it to the .env file, and load it in the AppConfig or LocationConfig, and there you can load it from the env with a fallback to R-
kkrawczyk123
force-pushed
the
OBPIH-6952
branch
from
63fa1d8 to
9018fdc
Compare
kkrawczyk123
force-pushed
the
OBPIH-6952
branch
from
9018fdc to
ac10934
Compare
awalkowiak
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test for asserting receiving bin location is created