OBPIH-6701 Add test for receiving through import template#53
Merged
awalkowiak merged 3 commits intomainfrom Apr 16, 2025
Merged
OBPIH-6701 Add test for receiving through import template#53awalkowiak merged 3 commits intomainfrom
awalkowiak merged 3 commits intomainfrom
Conversation
awalkowiak
requested changes
Apr 2, 2025
|
|
||
| get importTemplateButton() { | ||
| return this.page | ||
| .locator('[class="btn btn-outline-secondary btn-xs mr-3"]') |
Contributor
There was a problem hiding this comment.
Can we get a better locator here?
Collaborator
Author
There was a problem hiding this comment.
I think that now, we can't as this button differs from others and doesn't have role button:
| await test.step('Input receiving now qty into template', async () => { | ||
| const documentRow = parsedDocumentData[1]; | ||
| const row = [...documentRow]; | ||
| (row[11] = '20'), (row[12] = 'e2e-comment'); |
Contributor
There was a problem hiding this comment.
Can we add consts holding these column numbers that would describe what is behind it?
| await test.step('Input receiving now qty into template', async () => { | ||
| const documentRow = parsedDocumentData[1]; | ||
| const row = [...documentRow]; | ||
| (row[4] = 'editlot'), (row[11] = '20'), (row[12] = 'e2e-comment'); |
Contributor
There was a problem hiding this comment.
Can we add consts holding these column numbers that would describe what is behind it?
kkrawczyk123
force-pushed
the
OBPIH-6701
branch
from
fc82155 to
4ceca80
Compare
awalkowiak
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test for receiving through import template