illustrate unnecessary pad operation #147
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a tensor of size 1x161, padding it to 1x168 and then filling that tensor with zeroes, we should just create an empty tensor of 1x168 and fill with zeroes (no padding operation). It's important to remove the unnecessary padding operation, because later at bufferization, this results in an extra allocOp in L1 that we do not need.
dispatch-9-build-error.txt
build-output-with-padding.txt