feat: add BitVec zero/one simplifications #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgrosser
force-pushed
the
bv_zero_one_simps
branch
from
062c21b to
66c7855
Compare
…an up BVDecide - Fix names shiftLeft_zero_eq -> shiftLeft_zero ushiftRight_zero_eq -> ushiftRight_zero - Remove duplicate prefixes BitVec.mul_zero -> mul_zero BitVec.mul_add -> mul_add - Adapt BVDecide/Normalize/BitVec by reusing the following functions zero_add | add_zero and_self mul_zero | zero_mul shiftLeft_zero | zero_shiftLeft sshiftRight_zero | zero_sshiftRight ushiftRight_zero | zero_ushiftRight
tobiasgrosser
force-pushed
the
bv_zero_one_simps
branch
from
66c7855 to
4cff110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read this section before submitting
missing documentationormissing teststhen it needs fixing!RFCorbugissue in the description.leanprover/lean4-pr-releases:pr-release-NNNNfor Linux and M-series Macs will be generated upon build. To generate binaries for Windows and Intel-based Macs as well, write a comment containingrelease-cion its own line.nightly-with-mathlibthen CI will test Mathlib against your PR.awaiting-review,awaiting-author, andWIPlabels yourself, by writing a comment containing one of these labels on its own line.---before submitting.Closes #0000 (
RFCorbugissue number fixed by this PR, if any)