Skip to content

Task/585 reorg #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeNeilson merged 5 commits into from
Dec 11, 2025

Cleanup after merging main.

a638454
Select commit
Loading
Failed to load commit list.
Merged

Task/585 reorg #594

Cleanup after merging main.
a638454
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Dec 10, 2025 in 1m 16s

Quality Gate failed

Failed conditions
28.7% Coverage on New Code (required ≥ 30%)
4.7% Duplication on New Code (required ≤ 3%)
B Security Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 179 in java/opendcs-web-ui/src/main/webapp/resources/js/processes.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIQTQ79FBVovlEbT&open=AZr0UIQTQ79FBVovlEbT&pullRequest=594

Check failure on line 894 in java/opendcs-web-ui/src/main/webapp/resources/js/platforms.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIRKQ79FBVovlEeK&open=AZr0UIRKQ79FBVovlEeK&pullRequest=594

Check warning on line 1064 in java/opendcs-web-ui/src/main/webapp/resources/js/datatables/helpers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.isNaN` over `isNaN`. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UISKQ79FBVovlEnk&open=AZr0UISKQ79FBVovlEnk&pullRequest=594

Check failure on line 299 in java/opendcs-web-ui/src/main/webapp/resources/js/lib/opendcs_utilities.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UITZQ79FBVovlEth&open=AZr0UITZQ79FBVovlEth&pullRequest=594

Check failure on line 858 in java/opendcs-web-ui/src/main/webapp/resources/js/routing.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIVtQ79FBVovlE5E&open=AZr0UIVtQ79FBVovlE5E&pullRequest=594

Check warning on line 491 in java/opendcs-rest-api/src/main/java/org/opendcs/odcsapi/res/ConfigResources.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move the "None" string literal on the left side of this string comparison. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UImPQ79FBVovlFEs&open=AZr0UImPQ79FBVovlFEs&pullRequest=594

Check warning on line 263 in java/opendcs-rest-api/src/main/java/org/opendcs/odcsapi/res/RoutingResources.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move the "sc:daps_status" string literal on the left side of this string comparison. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UImFQ79FBVovlFER&open=AZr0UImFQ79FBVovlFER&pullRequest=594

Check warning on line 38 in java/opendcs-rest-api/src/main/java/org/opendcs/odcsapi/sec/openid/JwtVerifier.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A Singleton implementation was detected. Make sure the use of the Singleton pattern is required and the implementation is the right one for the context. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UImpQ79FBVovlFE0&open=AZr0UImpQ79FBVovlFE0&pullRequest=594

Check failure on line 1182 in java/opendcs-web-ui/src/main/webapp/resources/js/datatables/helpers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UISKQ79FBVovlEoF&open=AZr0UISKQ79FBVovlEoF&pullRequest=594

Check failure on line 865 in java/opendcs-web-ui/src/main/webapp/resources/js/routing.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIVtQ79FBVovlE5F&open=AZr0UIVtQ79FBVovlE5F&pullRequest=594

Check failure on line 867 in java/opendcs-web-ui/src/main/webapp/resources/js/routing.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIVtQ79FBVovlE5H&open=AZr0UIVtQ79FBVovlE5H&pullRequest=594

Check warning on line 41 in java/opendcs-web-ui/src/main/webapp/resources/js/netlist.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIRZQ79FBVovlEe9&open=AZr0UIRZQ79FBVovlEe9&pullRequest=594

Check warning on line 81 in java/opendcs-rest-api/src/main/java/org/opendcs/odcsapi/res/OdcsapiResource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this String concatenation with Text block. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIllQ79FBVovlFCg&open=AZr0UIllQ79FBVovlFCg&pullRequest=594

Check warning on line 864 in java/opendcs-web-ui/src/main/webapp/resources/js/computations.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'newOption' is already defined. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UISfQ79FBVovlErX&open=AZr0UISfQ79FBVovlErX&pullRequest=594

Check failure on line 39 in java/opendcs-web-ui/src/main/webapp/resources/js/sources.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIWGQ79FBVovlE6B&open=AZr0UIWGQ79FBVovlE6B&pullRequest=594

Check failure on line 1173 in java/opendcs-web-ui/src/main/webapp/resources/js/datatables/helpers.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UISKQ79FBVovlEn-&open=AZr0UISKQ79FBVovlEn-&pullRequest=594

Check failure on line 29 in java/opendcs-web-ui/src/main/webapp/resources/js/routing.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIVtQ79FBVovlE2Z&open=AZr0UIVtQ79FBVovlE2Z&pullRequest=594

Check warning on line 36 in java/opendcs-web-ui/src/main/java/portal/rledit/Enumerations.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this left curly brace to the beginning of next line of code. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIfkQ79FBVovlE_6&open=AZr0UIfkQ79FBVovlE_6&pullRequest=594

Check warning on line 14 in java/opendcs-web-ui/src/main/webapp/resources/js/layout.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIUbQ79FBVovlEvP&open=AZr0UIUbQ79FBVovlEvP&pullRequest=594

Check warning on line 628 in java/opendcs-web-ui/src/main/webapp/resources/js/datatables/datatables.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIR1Q79FBVovlEip&open=AZr0UIR1Q79FBVovlEip&pullRequest=594

Check failure on line 157 in java/opendcs-web-ui/src/main/webapp/resources/js/computations.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UISfQ79FBVovlEqP&open=AZr0UISfQ79FBVovlEqP&pullRequest=594

Check failure on line 389 in java/opendcs-web-ui/src/main/webapp/resources/js/routing.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIVtQ79FBVovlE3U&open=AZr0UIVtQ79FBVovlE3U&pullRequest=594

Check failure on line 582 in java/opendcs-web-ui/src/main/webapp/resources/js/configs.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function expects no arguments, but 1 was provided. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIU6Q79FBVovlEx2&open=AZr0UIU6Q79FBVovlEx2&pullRequest=594

Check failure on line 723 in java/opendcs-web-ui/src/main/webapp/resources/js/configs.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected var, use let or const instead. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIU6Q79FBVovlEyX&open=AZr0UIU6Q79FBVovlEyX&pullRequest=594

Check failure on line 33 in java/opendcs-web-ui/src/main/java/filter/ContentSecurityPolicy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=opendcs_rest_api&issues=AZr0UIgpQ79FBVovlFAd&open=AZr0UIgpQ79FBVovlFAd&pullRequest=594
View more details on SonarQubeCloud