fix: answer range format validation and error message in Numerical input#511
Conversation
|
Thanks for the pull request, @ihor-romaniuk! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 88.99% 88.99% -0.01%
==========================================
Files 248 248
Lines 4561 4570 +9
Branches 943 951 +8
==========================================
+ Hits 4059 4067 +8
- Misses 470 471 +1
Partials 32 32 ☔ View full report in Codecov by Sentry. |
|
@openedx/2u-tnl this is ready for review. Thanks! |
Pull Requests to frontend-app-authoring: openedx/frontend-app-authoring#1557
Description
These fixes validate input range format; it accepts the following response forms:
[1,10],[1, 10],[ 1,10 ],[ 1, 10 ],[1, 10 ],[ 1, 10],[1.1,10],[1.1,10.1],[1.1,10.1]and display error on incorrect format like:[1.10],[1;10],[1/10], etc.Steps to reproduce
Actual result
Nothing happened, in console there's error

Note: the same when user print additional bracket
Expected result
Some validation should be for field or some error message for user should be shown


Before save:
After save: