refactor: Editors - convert AnswerWidget, Button, ExpandableTextArea to TypeScript#1558
refactor: Editors - convert AnswerWidget, Button, ExpandableTextArea to TypeScript#1558bradenmacdonald wants to merge 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @bradenmacdonald - is this still in progress? |
|
@mphilbrick211 This work got stalled. I'd like to continue it at some point, but it probably makes sense to close it for now. |
This PR resolves the bug that shows assignment's weighted grades that do not sum to the correct total grade. When a learner's weighted grades round down to the nearest whole number, but the summation of the weighted grades will round to a higher percent than the pre-rounded summation. To clarify this for users, the assignment's weighted grade will now show 2 decimal points, matching the legacy display found in the grade graph. To further clarify the difference, a tooltip was added to show the learner the raw weighted grade and the rounded weighted grade.
Description
This is a continuation of my ongoing work to convert more of the editors code to TypeScript. This PR focuses on
AnswerWidget.Supporting information
Follows #1537
Private ref: MNG-4479
Testing instructions
Test the problem editor and make sure there are no regressions.
Other information
This will conflict with #1557 but it should be easy to resolve.