feat: alerts for acceptance of specific agreements.#2845
feat: alerts for acceptance of specific agreements.#2845
Conversation
|
Thanks for the pull request, @xitij2000! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
536c0c7 to
5b23100
Compare
6064038 to
0365c7b
Compare
0365c7b to
2c72e8d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2845 +/- ##
=======================================
Coverage 95.49% 95.50%
=======================================
Files 1330 1334 +4
Lines 30563 30648 +85
Branches 6711 6718 +7
=======================================
+ Hits 29187 29271 +84
- Misses 1320 1321 +1
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bfb1e49 to
b5bbe08
Compare
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
✅ I tested this on devstack
- created an agreement
- updated the MFE config
- The agreement modal appears for video and file upload
✅ I read through the code
✅ I checked for accessibility issues
❌ Includes documentation
…os pages Adds new generic components for gating certain features based on acceptance or acknowledgement of user agreements. It adds one alert that can be displayed where a feature (such as uploading) is blocked based on user agreeement, and it adds a wrapper component that disables the components inside it till the agreement has been accepted.
b5bbe08 to
e11b1d9
Compare
Description
This PR introduces two generic component for gating features behind accepting user agreements.
This will work with the API introduced in openedx/openedx-platform#35895
Supporting information
openedx/platform-roadmap#465
Testing instructions
Same as openedx/openedx-platform#35895
Other information
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'private-ref: https://tasks.opencraft.com/browse/BB-10396