fix: break with error on postgresql 14#38040
fix: break with error on postgresql 14#38040qasimgulzar wants to merge 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @qasimgulzar! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@ormsbee could you please review this PR. |
|
@sarina I have also tested https://github.com/qasimgulzar/tutor-contrib-postgresql plugin to setup single command instance. Could you please attache this plugin with openedx doc? |
Description
This pull request makes a targeted update to how PostgreSQL database types are specified in the
courseware/fields.pyfile. Specifically, it changes the type returned for PostgreSQL fromBIGSERIALtoBIGINTin both thedb_typeandrel_db_typemethods. This ensures that auto-incrementing behavior is not implicitly assumed and aligns with scenarios where a plain integer type is needed.Database type adjustments for PostgreSQL:
BIGSERIALtoBIGINTin thedb_typemethod ofcourseware/fields.pyto avoid implicit auto-increment and better match intended usage.rel_db_typemethod to returnBIGINTinstead ofBIGSERIALfor PostgreSQL, ensuring consistency in type handling.Useful information to include:
ERROR: both default and identity specified for column "id" of table "grades_persistentsubsectiongrade"Supporting information
It is because django is creating unsupported DDL.
Testing instructions
After adding fix re-applied migrations for Grades app it work this time.

It has also added ID column for both the tables

bitint (auto increment)which is desired type.Deadline
None