-
Notifications
You must be signed in to change notification settings - Fork 3
integrate sanity_checks.py into new validation program #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sagemaso
wants to merge
19
commits into
feature/validation_integration
Choose a base branch
from
feature/validation-sanity-checks-integration
base: feature/validation_integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
integrate sanity_checks.py into new validation program #1378
sagemaso
wants to merge
19
commits into
feature/validation_integration
from
feature/validation-sanity-checks-integration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦-integration' into feature/validation-sanity-checks-integration # Conflicts: # src/egon/data/validation/rules/custom/sanity/gas_grid.py
β¦.com:openego/egon-data into feature/validation-sanity-checks-integration
Member
|
You assigned me as reviewer. I can check as soon as draft mode is disabled and conflicts are resolved (do you need help with this?) |
3eda5ab to
b6806f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sagemaso/eGon-validation#9 .
Please add a brief description of the changes here.
π Pull Request Guidelines
π§βπ» Contributor Checklist
Before requesting a review, make sure you've completed all of the following:
(for more information on local test, check
toxin the Contributing section)(CI tests are automatically executed when creating a PR, you can see the results of the checks below)
(optional if no dataset changes are involved)
CHANGELOG.rstabout the changesAUTHORS.rstOptional:
π Reviewer Checklist
During your review, please check the following:
CHANGELOG.rstupdated accordingly?π Additional Notes (optional)
π‘ Tip: If you add multiple reviewers, clarify who should check what β this saves time and avoids duplicated efforts.