Skip to content

Conversation

@sagemaso
Copy link

Fixes sagemaso/eGon-validation#9 .

Please add a brief description of the changes here.

πŸ“‹ Pull Request Guidelines

Please read the Pull Request Guidelines carefully before creating your PR.


πŸ§‘β€πŸ’» Contributor Checklist

Before requesting a review, make sure you've completed all of the following:

  • All tests pass locally or via CI
    (for more information on local test, check tox in the Contributing section)
    (CI tests are automatically executed when creating a PR, you can see the results of the checks below)
  • Workflow has run at least once in Test mode
    (optional if no dataset changes are involved)
  • Relevant documentation is updated (API, new features, etc.)
  • Dataset-versions are updated when existing datasets are adjusted.
  • Added a note to CHANGELOG.rst about the changes
  • Added yourself to AUTHORS.rst

Optional:

  • Changes have been tested in Everything mode
  • Extend the checklist for reviewers: Which aspects should be reviewed in particular?
<!-- Example:
Please focus on validating the data handling in file XYZ.
-->

πŸ” Reviewer Checklist

During your review, please check the following:

  • Is the code clean, readable, and efficient? Are there any oddities or obvious inefficiencies?
  • Does the code work as expected? (should already be verified by contributor)
  • Do all tests pass? (see CI results)
  • Is the documentation complete and up to date?
  • Is CHANGELOG.rst updated accordingly?
  • Is all necessary metadata complete and correct?
    • If metadata is pending: Is there an appropriate issue filed?

πŸ“ Additional Notes (optional)


πŸ’‘ Tip: If you add multiple reviewers, clarify who should check what β€” this saves time and avoids duplicated efforts.

@sagemaso sagemaso requested a review from nesnoj January 19, 2026 10:35
@nesnoj
Copy link
Member

nesnoj commented Jan 19, 2026

You assigned me as reviewer. I can check as soon as draft mode is disabled and conflicts are resolved (do you need help with this?)

@nesnoj nesnoj mentioned this pull request Jan 19, 2026
15 tasks
@sagemaso sagemaso force-pushed the feature/validation_integration branch from 3eda5ab to b6806f1 Compare January 22, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants