Skip to content

Conversation

@ClaraBuettner
Copy link
Contributor

@ClaraBuettner ClaraBuettner commented Dec 16, 2021

Contributes to #572 .

Depends on #550

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the continuous-integration/run-everything-over-the-weekend- branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@ClaraBuettner ClaraBuettner marked this pull request as ready for review January 3, 2022 10:18
@ClaraBuettner ClaraBuettner requested a review from IlkaCu January 3, 2022 10:18
@ClaraBuettner
Copy link
Contributor Author

The control parameter was not set correctly for generator components. I fixed this, tested it in test mode and merged the branch again in the CI-branch.

@ClaraBuettner
Copy link
Contributor Author

@khelfen: Do you know if you need such parameters in edisgo?

@khelfen
Copy link
Contributor

khelfen commented May 12, 2025

@khelfen: Do you know if you need such parameters in edisgo?

Yeah, they are used in eDisGo 👍

@ClaraBuettner
Copy link
Contributor Author

Yeah, they are used in eDisGo 👍

And do you also rely on the data coming from eGon-data or do you set them differently in eDisGo?

@khelfen
Copy link
Contributor

khelfen commented May 12, 2025

Yeah, they are used in eDisGo 👍

And do you also rely on the data coming from eGon-data or do you set them differently in eDisGo?

I just rechecked: currently, the control parameter is not retrieved from the database — eDisGo defaults to "PQ" control for all generator types. I think it would be more robust to define this explicitly in eGon-data and load it via the DB in eDisGo, but the current default works.

To be honest, I'm not sure how much the different control settings influence the power flow results.

@nesnoj how is this handled in ding0?

Relevant code snippets in eDisGo:

Data retrieval:

Default values:


Möchtest du eine noch technischere oder neutralere Tonalität?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants