feat(dotnet-sdk): configurable client credentials token url#505
feat(dotnet-sdk): configurable client credentials token url#505alex-zyl wants to merge 1 commit intoopenfga:mainfrom
Conversation
|
|
5231b3f to
a203e06
Compare
|
Thanks for the PR @alex-zyl - sorry it's taking a bit longer to review, we're clearing through a backlog of .NET related changes and PRs and hopefully this week or early next week we can get this reviewed and merged |
|
No worries, @rhamzeh Luckily the issue with hardcoded token endpoint subpath can be workedaround by providing own instance of http client where we can overwrite request url |
|
Hey @alex-zyl, just an opinion; but seems to me we're not addressing the root issue, a better solution should involve Discovery, it might require some work though. On the other hand, if a workaround is to be provided, I think the PR might introduce edge cases and breaking changes on clients relying already on that PathTemplate; just and idea but why just not adding a new variable to the ClientConfiguration.Credentials and use it for the PathTemplate if not null? |
Description
Makes token endpoint configurable.
References
#238
Review Checklist
main