Remove redundant fga_client.close in python#545
Draft
davidroeca wants to merge 1 commit intoopenfga:mainfrom
Draft
Remove redundant fga_client.close in python#545davidroeca wants to merge 1 commit intoopenfga:mainfrom
davidroeca wants to merge 1 commit intoopenfga:mainfrom
Conversation
|
Author
|
Please hold off on review. I'm realizing I still need to factor in changes from #116 |
Member
Hi @davidroeca. While your refactoring and this PR is on hold, can you change it to |
fga_client.close() is handled by the context manager so it isn't needed, as discussed in openfga/python-sdk#191
f200d12 to
6826e93
Compare
Author
|
Hi @dyeam0 that makes sense to me, but unfortunately I don't see a way to do so |
Member
|
@davidroeca (for next time) it's from the side bar I marked it as draft for now - let us know when you believe is ready to review. Also please make sure to sign the Linux Foundation's CLA (#545 (comment)) when you are ready for it to be merged. It's a one time process, and without it we're restricted from merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
fga_client.close()is handled by the context manager so it isn't needed, as discussed in openfga/python-sdk#191References
Review Checklist
main