Fix product variants sometimes incorrectly hidden during OC creation #13603
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "New products can be put into my shopfront (recommended)" coordinator setting is enabled, product variants hidden in inventory should still be included in outgoing exchange step during OC creation.
sigmundpetersen
moved this from All the things 💤
to In Progress ⚙
in OFN Delivery board
|
Just checked and even if the spec is passing for me locally, it's not doing what I expected regardless. I'll try to figure this out (and also the divergence between my local env and CI). |
|
It may also be a "flaky" spec. I started a re-run of the failed spec, let's see if it's consistent |
|
Maybe! I'll try figure out how to make it non flaky if that's indeed the case. |
|
Yes it was flaky! |
|
Good! Still I'm not convinced this is the right solution, I'd like to look more into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
For now just looking to see if I broke some tests since CI takes a long time. I will fill the template more in detail once I convince myself that this solution makes sense.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates