Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 22, 2025

Bumps knapsack_pro from 8.1.2 to 8.4.0.

Changelog

Sourced from knapsack_pro's changelog.

8.4.0

KnapsackPro/knapsack_pro-ruby@v8.3.3...v8.4.0

8.3.3

KnapsackPro/knapsack_pro-ruby@v8.3.2...v8.3.3

8.3.2

  • Fix infinite recursion when the logger enters a loop. The issue occurs when KNAPSACK_PRO_LOG_DIR=log is set and a conflict arises between the values of environment variables from the CI provider and those configured by the user (e.g., KNAPSACK_PRO_CI_NODE_INDEX, KNAPSACK_PRO_CI_NODE_TOTAL).

    KnapsackPro/knapsack_pro-ruby#304

KnapsackPro/knapsack_pro-ruby@v8.3.1...v8.3.2

8.3.1

KnapsackPro/knapsack_pro-ruby@v8.3.0...v8.3.1

8.3.0

KnapsackPro/knapsack_pro-ruby@v8.2.0...v8.3.0

8.2.0

KnapsackPro/knapsack_pro-ruby@v8.1.3...v8.2.0

8.1.3

... (truncated)

Commits
  • af0050a Bump version 8.4.0
  • 3c133e8 Add a batch UUID to the V1 Queue API request payload to improve handling of r...
  • fed893e chore(test): remove unneeded blocks
  • fa3548c test: run time tracker specs with rspec
  • bbc0492 Update CHANGELOG.md
  • d396d93 Bump version 8.3.3
  • 73d1459 Fix a Hash#sum bug in the time tracker for RSpec (#305)
  • 618044c chore: update pull_request_template.md
  • 6f5a638 Bump version 8.3.2
  • cbf4a53 Fix infinite recursion when the logger enters a loop (#304)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 8.1.2 to 8.4.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/main/CHANGELOG.md)
- [Commits](KnapsackPro/knapsack_pro-ruby@v8.1.2...v8.4.0)

---
updated-dependencies:
- dependency-name: knapsack_pro
  dependency-version: 8.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Oct 22, 2025
@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Oct 22, 2025
@dependabot-pr-automation dependabot-pr-automation bot moved this from All the things 💤 to Code review 🔎 in OFN Delivery board Oct 22, 2025
@dacook dacook requested a review from filipefurtad0 October 27, 2025 23:29
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs pass, so I think all good.
FYI Filipe thought you might like to have a look.

Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Also from looking at CI test times, the splitting seems accurate.

Copy link
Contributor

@filipefurtad0 filipefurtad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dacook .

I'm not sure why did Dependabot not warn us about the upgrades between the current version and 8.4.0. Other than that, looks good 👍

@filipefurtad0 filipefurtad0 merged commit cdf0777 into master Oct 28, 2025
42 checks passed
@filipefurtad0 filipefurtad0 deleted the dependabot/bundler/knapsack_pro-8.4.0 branch October 28, 2025 12:31
@github-project-automation github-project-automation bot moved this from Code review 🔎 to Done in OFN Delivery board Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies ruby Pull requests that update Ruby code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants