Skip to content

Conversation

@deivid-rodriguez
Copy link
Contributor

What? Why?

Reviewdog (as configured by our linters workflow) is supposed to create checks for each linter and set them as failed is lint issues are found. See an example in my fork: https://github.com/deivid-rodriguez/openfoodnetwork/actions/runs/18717161451/job/53379580172.

I think this probably used to work until bd6bf93, because adding specific permissions to fetch the code automatically removed the rest of permissions.

What should we test?

I think, even if this is a PR from a fork, the new checks for rubocop and prettier should show up here. But we'll see.

Release notes

  • Technical changes only

@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Oct 22, 2025
@sigmundpetersen sigmundpetersen moved this from All the things 💤 to In Progress ⚙ in OFN Delivery board Oct 22, 2025
@deivid-rodriguez
Copy link
Contributor Author

Ok, so this PR did not create the "github checks" because it comes from a fork and GITHUB_TOKEN for PRs from forks has minimal permissions (it seems to ignore workflow permission configuration).

From linters' job logs:

reviewdog: This GitHub token doesn't have write permission of Review API [1], so reviewdog will report results via logging command [2] and create annotations similar to github-pr-check reporter as a fallback.
[1]: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target,
[2]: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#logging-commands

reviewdog: Reporting results for "prettier"
reviewdog: No results found for "prettier". 64 results found outside diff.

So updating the What should we test? section:

I'm pretty sure if a maintainer with write access to this repository recreates this same PR from a branch inside the repo, the checks will show up (I tried on my fork).

By the way, the fallback mentioned in logs probably did not work either because of missing permissions in the same way as permissions to write "github checks" are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Code review 🔎

Development

Successfully merging this pull request may close these issues.

1 participant