Closed
Conversation
Copilot
AI
changed the title
[WIP] Improve test suite runtime
Improve test suite runtime
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite had redundant per-test overhead from repeated force field parsing, unnecessary use of heavyweight code paths, and suboptimal CI configuration.
Changes
Fixture consolidation
xml_ff_bo_bondsandxml_ff_bo(raw XML strings requiringForceField(sage, xml_str)reconstruction in every test) withsage_bo_bondsandsage_bo_bothfixtures that return fully-combinedForceFieldobjects onceAvoid Interchange where it's not under test
test_fractional_bondorder_from_moleculenow callsforcefield.create_openmm_system()directly instead of converting throughInterchange.from_smirnoff()→to_openmm(), removing a heavyweight round-trip that wasn't exercising anything under testReduce charge assignment cost
test_virtual_site_type_stored_in_potential_keyfromsage(triggers NAGL charge assignment) tosage_no_nagl(falls back to cheaper formal charge method) since the test is about virtual site key types, not charge valuesCI / runner configuration
postinstall(pip install -e .) into a dedicated CI step rather than adepends-onon every pixi task, avoiding redundant re-installs-n logical→-n autoto use all available hardware threadsfail-fast: falseso matrix jobs run to completion and provide full signal on failures💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.