Skip to content

Improve test suite runtime#1463

Closed
Copilot wants to merge 1 commit intofix-slow-testsfrom
copilot/sub-pr-1460
Closed

Improve test suite runtime#1463
Copilot wants to merge 1 commit intofix-slow-testsfrom
copilot/sub-pr-1460

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 10, 2026

The test suite had redundant per-test overhead from repeated force field parsing, unnecessary use of heavyweight code paths, and suboptimal CI configuration.

Changes

Fixture consolidation

  • Replaced xml_ff_bo_bonds and xml_ff_bo (raw XML strings requiring ForceField(sage, xml_str) reconstruction in every test) with sage_bo_bonds and sage_bo_both fixtures that return fully-combined ForceField objects once

Avoid Interchange where it's not under test

  • test_fractional_bondorder_from_molecule now calls forcefield.create_openmm_system() directly instead of converting through Interchange.from_smirnoff()to_openmm(), removing a heavyweight round-trip that wasn't exercising anything under test

Reduce charge assignment cost

  • Switched test_virtual_site_type_stored_in_potential_key from sage (triggers NAGL charge assignment) to sage_no_nagl (falls back to cheaper formal charge method) since the test is about virtual site key types, not charge values

CI / runner configuration

  • Decoupled postinstall (pip install -e .) into a dedicated CI step rather than a depends-on on every pixi task, avoiding redundant re-installs
  • Changed -n logical-n auto to use all available hardware threads
  • Set fail-fast: false so matrix jobs run to completion and provide full signal on failures

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Mar 10, 2026
3 tasks
Copilot AI changed the title [WIP] Improve test suite runtime Improve test suite runtime Mar 10, 2026
@j-wags j-wags closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants