Switch to the @biomejs/biome formatter

.github/PULL_REQUEST_TEMPLATE.md

@@ -8,7 +8,6 @@ Describe the PR.
 - [ ] I process any text displayed to the user through translateText() and I've added it to the en.json file
 - [ ] I have added relevant tests to the test directory
 - [ ] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
-- [ ] I have read and accepted the CLA agreement (only required once).
 
 ## Please put your Discord username so you can be contacted if a bug or regression is found:
 

.github/workflows/ci.yml

@@ -70,4 +70,4 @@ jobs:
           node-version: "20"
           cache: "npm"
       - run: npm ci
-      - run: npx prettier --check .
+      - run: npx biome format .

.github/workflows/pr-description.yml

@@ -44,7 +44,6 @@ jobs:
               /- \[x\] I process any text displayed to the user through translateText\(\) and I\'ve added it to the en\.json file/i,
               /- \[x\] I have added relevant tests to the test directory/i,
               /- \[x\] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced/i,
-              /- \[x\] I have read and accepted the CLA agreement \(only required once\)\./i
             ];
 
             for (const box of requiredBoxes) {

.husky/pre-commit

@@ -1,6 +1,3 @@
-#!/usr/bin/env sh
-. "$(dirname -- "$0")/_/husky.sh"
-
 # Add PATH setup to ensure npx is found
 export PATH="/usr/local/bin:$HOME/.npm-global/bin:$HOME/.nvm/versions/node/$(node -v)/bin:$PATH"
 

.swcrc

@@ -0,0 +1,16 @@
+{
+  "jsc": {
+    "parser": {
+      "syntax": "typescript",
+      "tsx": true,
+      "decorators": true
+    },
+    "transform": {
+      "decoratorMetadata": true
+    },
+    "target": "es2022"
+  },
+  "module": {
+    "type": "es6"
+  }
+}

CODEOWNERS

@@ -2,3 +2,5 @@
 * @openfrontio/review-approver
 resources/lang @openfrontio/translation-approver
 resources/lang/en.json @openfrontio/review-approver
+src/client @openfrontio/frontend-approver
+src/server @openfrontio/backend-approver

Dockerfile

@@ -46,11 +46,12 @@ ENV NPM_CONFIG_IGNORE_SCRIPTS=1
 # Copy package.json and package-lock.json
 COPY package*.json ./
 # Install dependencies
-RUN npm ci --omit=dev
+RUN npm ci
 
 # Final image
 FROM base
-
+ARG GIT_COMMIT=unknown
+ENV GIT_COMMIT="$GIT_COMMIT"
 RUN apt-get update && apt-get install -y \
     nginx \
     supervisor \

README.md

@@ -139,7 +139,7 @@ Contributions are welcome! Please feel free to submit a Pull Request.
 Translators are welcome! Please feel free to help translate into your language.
 How to help?
 
-1. Request to join the translation [Discord](https://discord.gg/rUukAnz4Ww)
+1. Request to join the dev [Discord](https://discord.gg/K9zernJB5z) (in the application form, say you want to help translate)
 1. Go to the project's Crowdin translation page: [https://crowdin.com/project/openfront-mls](https://crowdin.com/project/openfront-mls)
 1. Login if you already have an account/ Sign up if you don't have one
 1. Select the language you want to translate in/ If your language isn't on the list, click the "Request New Language" button and enter the language you want added there.

biome.json

@@ -0,0 +1,49 @@
+{
+  "$schema": "https://biomejs.dev/schemas/2.2.2/schema.json",
+  "assist": {
+    "actions": {
+      "source": {
+        "organizeImports": "on"
+      }
+    },
+    "enabled": true
+  },
+  "files": {
+    "ignoreUnknown": true
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 2
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "double"
+    }
+  },
+  "linter": {
+    "enabled": false
+  },
+  "overrides": [
+    {
+      "assist": {
+        "actions": {
+          "source": {
+            "useSortedKeys": "on"
+          }
+        }
+      },
+      "includes": [
+        "eslint-plugin-local/**/*.{js,ts,jsx,tsx}",
+        "src/**/*.{js,ts,jsx,tsx}",
+        "**/*.test.{js,ts,jsx,tsx}",
+        "tests/**/*.{js,ts,jsx,tsx}"
+      ]
+    }
+  ],
+  "vcs": {
+    "clientKind": "git",
+    "enabled": true,
+    "useIgnoreFile": true
+  }
+}

eslint-plugin-local/plugin.js

@@ -0,0 +1,7 @@
+import noZArray from "./rules/no-z-array.js";
+
+export default {
+  rules: {
+    "no-z-array": noZArray,
+  },
+};

eslint-plugin-local/rules/no-z-array.js

@@ -0,0 +1,35 @@
+export default {
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (
+          node.callee.type === "MemberExpression" &&
+          node.callee.object.name === "z" &&
+          node.callee.property.name === "array" &&
+          node.arguments.length === 1
+        ) {
+          const argSource = context.sourceCode.getText(node.arguments[0]);
+          context.report({
+            data: { type: argSource },
+            fix(fixer) {
+              return fixer.replaceText(node, `${argSource}.array()`);
+            },
+            messageId: "noZArray",
+            node,
+          });
+        }
+      },
+    };
+  },
+  meta: {
+    docs: {
+      description: "Disallow z.array(type) in favor of type.array()",
+    },
+    fixable: "code",
+    messages: {
+      noZArray: "Use `{{type}}.array()` instead of `z.array({{type}})`.",
+    },
+    schema: [],
+    type: "suggestion",
+  },
+};

eslint.config.js

@@ -1,10 +1,12 @@
+import path from "node:path";
+import { fileURLToPath } from "node:url";
 import { includeIgnoreFile } from "@eslint/compat";
 import pluginJs from "@eslint/js";
-import eslintConfigPrettier from "eslint-config-prettier/flat";
+import stylistic from "@stylistic/eslint-plugin";
+import jest from "eslint-plugin-jest";
 import globals from "globals";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
 import tseslint from "typescript-eslint";
+import eslintPluginLocal from "./eslint-plugin-local/plugin.js";
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -18,13 +20,14 @@ export default [
   { languageOptions: { globals: { ...globals.browser, ...globals.node } } },
   pluginJs.configs.recommended,
   ...tseslint.configs.recommended,
-  eslintConfigPrettier,
   {
     languageOptions: {
       parserOptions: {
         projectService: {
           allowDefaultProject: [
             "__mocks__/fileMock.js",
+            "eslint-plugin-local/plugin.js",
+            "eslint-plugin-local/rules/no-z-array.js",
             "eslint.config.js",
             "jest.config.ts",
             "postcss.config.js",
@@ -39,17 +42,134 @@ export default [
   {
     rules: {
       // Disable rules that would fail. The failures should be fixed, and the entries here removed.
-      "@typescript-eslint/no-explicit-any": "off",
-      "@typescript-eslint/no-unused-expressions": "off",
-      "@typescript-eslint/no-unused-vars": "off",
-      "no-case-declarations": "off",
+      "@typescript-eslint/no-unused-expressions": "off", // https://github.com/openfrontio/OpenFrontIO/issues/1790
+      "no-case-declarations": "off", // https://github.com/openfrontio/OpenFrontIO/issues/1791
     },
   },
   {
+    plugins: {
+      "@stylistic": stylistic,
+    },
     rules: {
       // Enable rules
+      "@stylistic/quotes": ["error", "double", { avoidEscape: true }],
+      "@stylistic/semi": "error",
+      "@stylistic/space-infix-ops": "error",
+      "@stylistic/type-annotation-spacing": [
+        "error",
+        {
+          after: true,
+          before: true,
+          overrides: {
+            colon: {
+              before: false,
+            },
+          },
+        },
+      ],
+      "@stylistic/eol-last": "error",
+      "@typescript-eslint/consistent-type-definitions": ["error", "type"],
+      "@typescript-eslint/no-duplicate-enum-values": "error",
+      "@typescript-eslint/no-explicit-any": "error",
+      "@typescript-eslint/no-inferrable-types": "error",
+      "@typescript-eslint/no-mixed-enums": "error",
+      "@typescript-eslint/no-non-null-assertion": "error",
+      "@typescript-eslint/no-require-imports": "error",
+      "@typescript-eslint/no-unnecessary-type-assertion": "error",
+      "@typescript-eslint/prefer-as-const": "error",
+      "@typescript-eslint/prefer-function-type": "error",
+      "@typescript-eslint/prefer-includes": "error",
+      "@typescript-eslint/prefer-literal-enum-member": "error",
       "@typescript-eslint/prefer-nullish-coalescing": "error",
+      "@typescript-eslint/prefer-readonly": "error",
       eqeqeq: "error",
+      "@typescript-eslint/no-unsafe-argument": "error",
+      "@typescript-eslint/no-unsafe-assignment": "error",
+      "@typescript-eslint/no-unsafe-member-access": "error",
+      // "@typescript-eslint/no-unused-vars": ["error", { argsIgnorePattern: "^_" }], // TODO: Enable this rule, https://github.com/openfrontio/OpenFrontIO/issues/1784
+      "@typescript-eslint/no-unused-vars": "off",
+      "@typescript-eslint/prefer-for-of": "error",
+      "array-bracket-newline": ["error", "consistent"],
+      "array-bracket-spacing": ["error", "never"],
+      "array-element-newline": ["error", "consistent"],
+      "arrow-parens": ["error", "always"],
+      "comma-dangle": ["error", "always-multiline"],
+      "comma-spacing": ["error", { before: false, after: true }],
+      "func-call-spacing": ["error", "never"],
+      "function-call-argument-newline": ["error", "consistent"],
+      "max-depth": ["error", { max: 5 }],
+      "max-len": ["error", { code: 120 }],
+      "max-lines": [
+        "error",
+        { max: 677, skipBlankLines: true, skipComments: true },
+      ],
+      "max-lines-per-function": ["error", { max: 561 }],
+      "no-loss-of-precision": "error",
+      "no-multi-spaces": "error",
+      "no-multiple-empty-lines": ["error", { max: 1, maxEOF: 0 }],
+      "no-trailing-spaces": "error",
+      "object-curly-newline": ["error", { multiline: true, consistent: true }],
+      "object-curly-spacing": ["error", "always"],
+      "object-property-newline": [
+        "error",
+        { allowAllPropertiesOnSameLine: true },
+      ],
+      "object-shorthand": ["error", "always"],
+      "no-undef": "error",
+      "no-unused-vars": "off", // @typescript-eslint/no-unused-vars
+      "prefer-destructuring": [
+        "error",
+        {
+          array: false,
+          object: true,
+        },
+      ],
+      "quote-props": ["error", "as-needed"],
+      "space-before-blocks": ["error", "always"],
+      "space-before-function-paren": [
+        "error",
+        {
+          anonymous: "always",
+          named: "never",
+          asyncArrow: "always",
+        },
+      ],
+      "space-infix-ops": "off",
+    },
+  },
+  {
+    files: [
+      "**/*.config.{js,ts,jsx,tsx}",
+      "**/*.test.{js,ts,jsx,tsx}",
+      "tests/**/*.{js,ts,jsx,tsx}",
+      "eslint-plugin-local/**/*.{js,ts,jsx,tsx}",
+    ],
+    rules: {
+      // Disabled rules for tests, configs
+      "@typescript-eslint/no-explicit-any": "off",
+      "@typescript-eslint/no-non-null-assertion": "off",
+      "@typescript-eslint/no-unsafe-argument": "off",
+      "@typescript-eslint/no-unsafe-assignment": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "max-len": "off",
+    },
+  },
+  {
+    languageOptions: {
+      globals: {
+        ...globals.jest,
+      },
+    },
+    files: ["**/*.test.{js,ts,jsx,tsx}", "tests/**/*.{js,ts,jsx,tsx}"],
+    plugins: ["jest"],
+    ...jest.configs["flat/style"],
+  },
+  {
+    plugins: {
+      local: eslintPluginLocal,
+    },
+    rules: {
+      "local/no-z-array": "error",
     },
   },
 ];

jest.config.ts

@@ -10,22 +10,9 @@ export default {
     "\\.(css|less)$": "<rootDir>/__mocks__/fileMock.js",
   },
   transform: {
-    "^.+\\.tsx?$": [
-      "ts-jest",
-      {
-        useESM: true,
-        tsconfig: {
-          target: "ES2020",
-          module: "es2022",
-          moduleResolution: "node",
-          experimentalDecorators: true,
-          types: ["jest", "node"],
-        },
-      },
-    ],
+    "^.+\\.tsx?$": ["@swc/jest"],
   },
   transformIgnorePatterns: ["node_modules/(?!(node:)/)"],
-  preset: "ts-jest/presets/default-esm",
   collectCoverageFrom: ["src/**/*.ts", "!src/**/*.d.ts"],
   coverageThreshold: {
     global: {