Highlight clickable text event by underscoring them on desktop

[martinIvovIv]

Description:

Underscores clickable text in the event display window on desktop.
This improves the general accessability and new player experience.

Please complete the following:

• I have added screenshots for all UI updates
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
• I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

---

Desktop Image:

---

Mobile Image:
N/A

Please put your Discord username so you can be contacted if a bug or regression is found:

Discord username: martoi

---

Signed-off-by: MartinIvovIv https://github.com/martinIvovIv

[APuddle210]

For the examples in the screenshot, do all of those actually do something when being clicked?

[martinIvovIv]

For the examples in the screenshot, do all of those actually do something when being clicked?

Short answer: yes, they take the player to the target event.

Some of the event messages are actually buttons as seen on the code, those buttons have on click functions, for example:
@click=${() => this.emitGoToPlayerEvent(attack.targetID)}

I added the underline only to the actions that have functionality, nothing more or less.
It's a minor improvement and I would love if more people add feedback

[coderabbitai]

Walkthrough

This change updates the visual styling of several button elements in the EventsDisplay component by adding Tailwind CSS classes for underlining on medium and larger screens. The update standardizes underline effects, including dynamic underline offset on hover, without modifying any functional logic or component interfaces.

Changes

File(s)	Change Summary
src/client/graphics/layers/EventsDisplay.ts	Added Tailwind CSS classes to specific <button> elements for consistent underline styling on md+ screens.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EventsDisplay
    User->>EventsDisplay: Render event list
    EventsDisplay->>User: Display buttons with updated underline styling (md+ screens)

Loading

Possibly related issues

• Highlight clickable text event by underscoring them on desktop #620: Both address adding underline styling to clickable text in the event display component for better visual cues on desktop.

Poem

A dash of style, a line so fine,
Buttons now underline, right on time!
On bigger screens, they gleam and show,
With hover flair, their offsets grow.
The rabbit hops, with CSS delight—
Underlines shining, crisp and bright!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-20T20_28_29_204Z-debug-0.log

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 228f5b1 and 0cb9329.

📒 Files selected for processing (1)

• src/client/graphics/layers/EventsDisplay.ts (4 hunks)

🔇 Additional comments (4)

src/client/graphics/layers/EventsDisplay.ts (4)

489-493: Underlined styling added to incoming attack buttons
Visually distinguishes clickable attacker names on desktop, improving accessibility and user guidance.

---

522-524: Underlined styling added to outgoing attack buttons
Ensures consistency in indicating interactivity for outgoing attack targets on medium+ viewports.

---

591-593: Underlined styling added to boat buttons
Boat elements now clearly signal clickability in line with other interactive controls on desktop.

---

683-686: Underlined styling added to focusable event description buttons
Event descriptions that trigger navigation are now underlined on desktop, aligning with the PR's accessibility goals.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[TheGiraffe3]

Could you resolve conflicts?

[github-actions]

This pull request is stale because it has been open for fourteen days with no activity. If you want to keep this pull request open, add a comment or update the branch.