Skip to content

implement GROUP_MLKEM768X25519 w/ mlkem-code from openssh#138

Open
mfriedl wants to merge 1 commit intoopeniked:masterfrom
mfriedl:mlkem768x25519
Open

implement GROUP_MLKEM768X25519 w/ mlkem-code from openssh#138
mfriedl wants to merge 1 commit intoopeniked:masterfrom
mfriedl:mlkem768x25519

Conversation

@mfriedl
Copy link
Contributor

@mfriedl mfriedl commented Mar 31, 2025

No description provided.

@mfriedl mfriedl force-pushed the mlkem768x25519 branch 3 times, most recently from 87ba780 to c95ceca Compare March 31, 2025 17:14
@tobhe
Copy link
Member

tobhe commented Apr 5, 2025

I fixed all the CI pipelines in master, if you rebase and push again they might actually work :)

@mfriedl
Copy link
Contributor Author

mfriedl commented Apr 5, 2025

I've rebased

@mfriedl
Copy link
Contributor Author

mfriedl commented Apr 5, 2025

hm, compat/endian.h still has some issues....

@tobhe
Copy link
Member

tobhe commented Apr 5, 2025

Looks like macos needs some special magic for endian.h. They seem to have libkern/OSByteOrder.h which we could use to add a compat wrapper for the missing conversions.

EDIT: We already have https://github.com/openiked/openiked-portable/blob/master/compat/endian.h#L13-L23

EDIT2: Just saw that the commit actually adds the missing ones...

EDIT3: Missing an #include <endian.h> in iked/dh.c


#include "dh.h"
#include "iked.h"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include <endian.h>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants