feat: Add holidays for South Africa #525
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confusedbuffalo
force-pushed
the
za-holidays
branch
from
e82f032 to
db8ca4d
Compare
confusedbuffalo
force-pushed
the
za-holidays
branch
from
db8ca4d to
8894af4
Compare
confusedbuffalo
force-pushed
the
za-holidays
branch
from
8894af4 to
17644c5
Compare
confusedbuffalo
force-pushed
the
za-holidays
branch
from
17644c5 to
704231d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://www.gov.za/about-sa/public-holidays "The Act determines whenever any public holiday falls on a Sunday, the Monday following on it shall be a public holiday." so I had to add helpers for each holiday.
Also, the school terms are named (term 1 to term 4) and the holidays do not seem to have any official names, so I have essentially given them placeholder names.