8375010: C2 VectorAPI: assert(vbox->is_CheckCastPP()) failed: should be expanded

[0zzy0sbourne]

This is a backport of JDK-8375010

The check vect->is_Vector() || vect->is_LoadVector() in expand_vbox_node_helper does not handle Proj nodes that resolve to vector types, causing an assertion failure when such nodes flow through a Phi into VectorBox. The fix handles these two additional cases (VectorBox inside a Phi or Proj node), preventing the assert crash.

Tested: VectorBoxExpandPhi.java and VectorBoxExpandProj.java pass.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8374903 needs maintainer approval
• JDK-8375010 needs maintainer approval

Issues

• JDK-8375010: C2 VectorAPI: assert(vbox->is_CheckCastPP()) failed: should be expanded (Bug - P3 - Requested)
• JDK-8374903: C2 VectorAPI: assert(vbox->as_Phi()->region() == vect->as_Phi()->region()) failed (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/426/head:pull/426
$ git checkout pull/426

Update a local copy of the PR:
$ git checkout pull/426
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 426

View PR using the GUI difftool:
$ git pr show -t 426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/426.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back 0zzy0sbourne! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[openjdk]

⚠️ @0zzy0sbourne This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (c3f755c6)

[0zzy0sbourne]

/approval request for backport of JDK-8375010: C2 VectorAPI: assert(vbox->is_CheckCastPP()) failed: should be expanded.

This is a bug where expand_vbox_node_helper hits a fatal assert when the vector box node is not a CheckCastPP as expected. The check vect->is_Vector() || vect->is_LoadVector() does not handle Proj nodes that resolve to vector types, causing an assertion failure when such nodes flow through a Phi into VectorBox. Fixing this is important as it causes a hard JVM crash during Vector API compilation with no recovery path. The fix handles these two additional cases (VectorBox inside a Phi or Proj node), preventing the assert crash. The risk is low, the change is well-contained within expand_vbox_node_helper and adds handling for previously unhandled graph shapes without modifying existing logic. The patch from the JDK Project applies cleanly with no conflicts. Test coverage: VectorBoxExpandPhi.java and VectorBoxExpandProj.java pass.

[openjdk]

@0zzy0sbourne
8375010: The approval request has been created successfully.
8374903: The approval request has been created successfully.

[officialmclars]

Hi @officialmclars, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user officialmclars" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

• I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

[openjdk]

@officialmclars Only the author (@0zzy0sbourne) is allowed to issue the integrate command.