8377512: AOT cache creation fails with invalid native pointer

[antonvoznia]

It's not clean backport:

Removed
rejection_reason = "(not dumping method handles)";
rejection_reason = "(not dumping intrinsic method handles)";
JDK 25 doesn't use the rejection_reason, it requires another backport .

Function ConstantPoolCache::can_archive_resolved_method(ConstantPool* src_cp, ResolvedMethodEntry* method_entry) was a bit re-implemented, because the original fix uses logic based on "8334898: Resolve static field/method references at CDS dump time" changes within this function.

Testing:

1. Reproducer.

2. tests test/hotspot/jtreg/runtime/cds/appcds/aotCache/
   Without fix
   Test results: passed: 11; failed: 5; error: 1
   With fix
   Test results: passed: 15; failed: 1; error: 1

3. OpenJDK GHA Sanity Checks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8377512 needs maintainer approval

Issue

• JDK-8377512: AOT cache creation fails with invalid native pointer (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/428/head:pull/428
$ git checkout pull/428

Update a local copy of the PR:
$ git checkout pull/428
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 428

View PR using the GUI difftool:
$ git pr show -t 428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/428.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back antonvoznia! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (3646fe3f)
• 01: Full - Incremental (41ead06b)
• 00: Full (3a7fb8f1)

[iklam]

By removing this, does it disable all AOT-resolution of invokehandle bytecodes?

You can try with a test like this:

import java.lang.invoke.*;
 
public class HelloMH {
    public static void main(String ...args) throws Throwable {
        MethodHandles.Lookup lookup = MethodHandles.lookup();
        MethodType mt = MethodType.methodType(void.class, float.class);
        MethodHandle mh = lookup.findStatic(HelloMH.class, "callme", mt);
        HelloMHCaller.call(mh);
    }
 
    private static void callme(float x) {
        System.out.println("Hello MH.invoke: " + x);
        Thread.dumpStack();
    }
}

class HelloMHCaller {
  static void call(MethodHandle mh) throws Throwable {
    mh.invokeExact(4.0f);
  }
}

and see if the invokehandle bytecode in HelloMHCaller::call is AOT-resolved or reverted.

[iklam]

Looks good, but I have one question about one of the changes.