Skip to content

8376185: NoSuchFieldError thrown after a record with type annotation retransformed#433

Open
jpbempel wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-jpbempel-0c60c9ca-master
Open

8376185: NoSuchFieldError thrown after a record with type annotation retransformed#433
jpbempel wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-jpbempel-0c60c9ca-master

Conversation

@jpbempel
Copy link
Copy Markdown
Member

@jpbempel jpbempel commented Mar 31, 2026

Hi all,

This pull request contains a backport of commit 0c60c9ca from the openjdk/jdk repository.

The commit being backported was authored by Jean-Philippe Bempel on 25 Mar 2026 and was reviewed by Serguei Spitsyn and David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8376185 needs maintainer approval

Issue

  • JDK-8376185: NoSuchFieldError thrown after a record with type annotation retransformed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/433/head:pull/433
$ git checkout pull/433

Update a local copy of the PR:
$ git checkout pull/433
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 433

View PR using the GUI difftool:
$ git pr show -t 433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/433.diff

Using Webrev

Link to Webrev Comment

@jpbempel jpbempel closed this Mar 31, 2026
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 31, 2026

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jpbempel jpbempel reopened this Mar 31, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 0c60c9ca1477a114a9c7095226d3a1e5d31600fb 8376185: NoSuchFieldError thrown after a record with type annotation retransformed Mar 31, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 31, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

⚠️ @jpbempel This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 31, 2026

Webrevs

@jpbempel
Copy link
Copy Markdown
Member Author

jpbempel commented Mar 31, 2026

/approval request retransformation on a record with type annotation on a record component leads to a corrupted state in the JVM memory. Best cases we have an exception, worst cases a JVM crash. It is common to use type annotation like @NotNull on the record components.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

@jpbempel
8376185: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 31, 2026
@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Apr 1, 2026

Hi @jpbempel
Can you please backport to 26 first. Then you can request approval again.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants