8362659: Remove sun.print.PrintJob2D.finalize()#439
8362659: Remove sun.print.PrintJob2D.finalize()#439rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8362659: Remove sun.print.PrintJob2D.finalize(). This PR removes the redundant finalize() override from PrintJob2D since the superclass java.awt.PrintJob.finalize() already calls end(), making the override unnecessary. This is a prerequisite for JDK-8378417 which will be added as a dependent PR (#441) for parity with Oracle JDK. Negligible risk — this removes a redundant method override. |
|
Hi @rm-gh-8 |
Backporting JDK-8362659: Remove sun.print.PrintJob2D.finalize().
This PR removes the redundant finalize() override from PrintJob2D since the superclass java.awt.PrintJob.finalize() already calls end(), making the override unnecessary.
This is a prerequisite for JDK-8378417, which will be added as a dependent PR (#441) for parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/awt/PrintJob
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/439/head:pull/439$ git checkout pull/439Update a local copy of the PR:
$ git checkout pull/439$ git pull https://git.openjdk.org/jdk25u-dev.git pull/439/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 439View PR using the GUI difftool:
$ git pr show -t 439Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/439.diff
Using Webrev
Link to Webrev Comment