Skip to content

8362659: Remove sun.print.PrintJob2D.finalize()#439

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8362659-V25
Open

8362659: Remove sun.print.PrintJob2D.finalize()#439
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8362659-V25

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Mar 31, 2026

Backporting JDK-8362659: Remove sun.print.PrintJob2D.finalize().

This PR removes the redundant finalize() override from PrintJob2D since the superclass java.awt.PrintJob.finalize() already calls end(), making the override unnecessary.

This is a prerequisite for JDK-8378417, which will be added as a dependent PR (#441) for parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/java/awt/PrintJob

Results attached:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log


Progress

  • Change must not contain extraneous whitespace
  • JDK-8362659 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8362659: Remove sun.print.PrintJob2D.finalize() (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/439/head:pull/439
$ git checkout pull/439

Update a local copy of the PR:
$ git checkout pull/439
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/439/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 439

View PR using the GUI difftool:
$ git pr show -t 439

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/439.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 31, 2026

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b8da9695f0cc049d6a07a7382afce4d22f8b2b1c 8362659: Remove sun.print.PrintJob2D.finalize() Mar 31, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 31, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 31, 2026 16:51
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 31, 2026

Webrevs

@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Apr 1, 2026

/approval request for backport of JDK-8362659: Remove sun.print.PrintJob2D.finalize().

This PR removes the redundant finalize() override from PrintJob2D since the superclass java.awt.PrintJob.finalize() already calls end(), making the override unnecessary.

This is a prerequisite for JDK-8378417 which will be added as a dependent PR (#441) for parity with Oracle JDK.

Negligible risk — this removes a redundant method override.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@rm-gh-8
8362659: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Apr 1, 2026
@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Apr 7, 2026

Hi @rm-gh-8
I don't understand why this is a prereq of JDK-8378417.

@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Apr 7, 2026

@GoeLin JDK-8378417 (#441) depends on JDK-8363889 (#440), and JDK-8363889 (#440) depends on JDK-8362659 (due to changes in "src/java.desktop/share/classes/sun/print/PrintJob2D.java").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants