8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call#442
8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call#442rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call. This is a test fix. For parity with Oracle JDK. |
|
/integrate |
|
Going to push as commit 7705b59.
Your commit was automatically rebased without conflicts. |
Backporting JDK-8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call.
This PR improves GetXSpace.java test diagnostics by wrapping the native getSpace0() call to print the file path, existence, and readability on failure, and fixes two incorrect bitwise-AND operators..
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/io/File/GetXSpace.java
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/442/head:pull/442$ git checkout pull/442Update a local copy of the PR:
$ git checkout pull/442$ git pull https://git.openjdk.org/jdk25u-dev.git pull/442/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 442View PR using the GUI difftool:
$ git pr show -t 442Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/442.diff
Using Webrev
Link to Webrev Comment