Skip to content

8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call#442

Closed
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8372851-V25
Closed

8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call#442
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8372851-V25

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Mar 31, 2026

Backporting JDK-8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call.

This PR improves GetXSpace.java test diagnostics by wrapping the native getSpace0() call to print the file path, existence, and readability on failure, and fixes two incorrect bitwise-AND operators..

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/java/io/File/GetXSpace.java

Results attached:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372851 needs maintainer approval

Issue

  • JDK-8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/442/head:pull/442
$ git checkout pull/442

Update a local copy of the PR:
$ git checkout pull/442
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 442

View PR using the GUI difftool:
$ git pr show -t 442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/442.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 31, 2026

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ba777f6610fa3744d5f4bdfb87066b137ab543af 8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call Mar 31, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 31, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 31, 2026 18:37
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 31, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 31, 2026

Webrevs

@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Apr 1, 2026

/approval request for backport of JDK-8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call.

This is a test fix.

For parity with Oracle JDK.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@rm-gh-8
8372851: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 1, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Apr 7, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 7, 2026

Going to push as commit 7705b59.
Since your change was applied there have been 9 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2026
@openjdk openjdk bot closed this Apr 7, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 7, 2026

@rm-gh-8 Pushed as commit 7705b59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant