Skip to content

8359433: The final modifier on Windows L&F internal UI classes prevents extending them in apps#445

Open
mrserb wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-mrserb-0d251968-master
Open

8359433: The final modifier on Windows L&F internal UI classes prevents extending them in apps#445
mrserb wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-mrserb-0d251968-master

Conversation

@mrserb
Copy link
Copy Markdown
Member

@mrserb mrserb commented Apr 1, 2026

Hi all,

This pull request contains a backport of commit 0d251968 from the openjdk/jdk26u repository.

The commit being backported was authored by Sergey Bylokhov on 1 Apr 2026 and had no reviewers.

The change is clean.

Thanks!

The reason for the fix (copied from mainline):

JDK-8352638 added final to public classes in java.desktop/windows including the Windows L&F package as a code consistency cleanup. This breaks applications that extend UI classes and they get IncompatibleClassChangeError at runtime.

Although this package is not part of the public API, we decided to remove the final modifier from all public and protected classes, as well as their inner classes in com.sun.java.swing.plaf.windows. Package-private classes, private inner classes, and the @Override annotations introduced by JDK-8352638 remain unchanged.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359433 needs maintainer approval

Issue

  • JDK-8359433: The final modifier on Windows L&F internal UI classes prevents extending them in apps (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/445/head:pull/445
$ git checkout pull/445

Update a local copy of the PR:
$ git checkout pull/445
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 445

View PR using the GUI difftool:
$ git pr show -t 445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/445.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 1, 2026

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359433: The final modifier on Windows L&F internal UI classes prevents extending them in apps

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • be7cad4: 8374343: Fix SIGSEGV when lib/modules is unreadable

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0d251968c02295c1cc64fbaff0522d767a84b284 8359433: The final modifier on Windows L&F internal UI classes prevents extending them in apps Apr 1, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 1, 2026
@mrserb
Copy link
Copy Markdown
Member Author

mrserb commented Apr 2, 2026

/approval request
Clean backport. The final modifier has been removed from internal UI Windows L&F classes.

@mrserb mrserb marked this pull request as ready for review April 2, 2026 01:36
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 2, 2026

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 2, 2026

@mrserb
8359433: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Apr 2, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 2, 2026

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant