8378878: Refactor java/nio/channels/AsynchronousSocketChannel test to use JUnit#448
8378878: Refactor java/nio/channels/AsynchronousSocketChannel test to use JUnit#448rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8378878: Refactor java/nio/channels/AsynchronousSocketChannel test to use JUnit. This is a test fix. For parity with Oracle JDK. |
Backporting JDK-8378878: Refactor java/nio/channels/AsynchronousSocketChannel test to use JUnit.
This PR refactors CompletionHandlerRelease.java from TestNG to JUnit 5 as part of ongoing test framework migration.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/nio/channels/AsynchronousSocketChannel/CompletionHandlerRelease.java
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/448/head:pull/448$ git checkout pull/448Update a local copy of the PR:
$ git checkout pull/448$ git pull https://git.openjdk.org/jdk25u-dev.git pull/448/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 448View PR using the GUI difftool:
$ git pr show -t 448Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/448.diff
Using Webrev
Link to Webrev Comment