8367473: Shenandoah: Make the detailed evacuation metrics a runtime diagnostic option#449
Conversation
…iagnostic option 8367722: [GenShen] ShenandoahEvacuationStats is always empty Reviewed-by: ysr, phh
|
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
|
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issues from the original commit. |
|
|
|
/approval request This change converts a non-product only build time option into a runtime option. This option has provided very valuable performance debugging data from release builds. This change only affects Shenandoah code. We (Amazon) have enabled this option in production-like environments and we see no significant performance impact when the option is disabled. |
|
@earthling-amzn |
Conflict on pacer, not hard to resolve
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/449/head:pull/449$ git checkout pull/449Update a local copy of the PR:
$ git checkout pull/449$ git pull https://git.openjdk.org/jdk25u-dev.git pull/449/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 449View PR using the GUI difftool:
$ git pr show -t 449Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/449.diff
Using Webrev
Link to Webrev Comment