Skip to content

8367473: Shenandoah: Make the detailed evacuation metrics a runtime diagnostic option#449

Open
earthling-amzn wants to merge 1 commit intoopenjdk:masterfrom
earthling-amzn:backport-8367473-to-25u-dev
Open

8367473: Shenandoah: Make the detailed evacuation metrics a runtime diagnostic option#449
earthling-amzn wants to merge 1 commit intoopenjdk:masterfrom
earthling-amzn:backport-8367473-to-25u-dev

Conversation

@earthling-amzn
Copy link
Copy Markdown

@earthling-amzn earthling-amzn commented Apr 6, 2026

Conflict on pacer, not hard to resolve


Progress

  • JDK-8367473 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8367722 needs maintainer approval

Issues

  • JDK-8367473: Shenandoah: Make the detailed evacuation metrics a runtime diagnostic option (Enhancement - P4 - Approved)
  • JDK-8367722: [GenShen] ShenandoahEvacuationStats is always empty (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/449/head:pull/449
$ git checkout pull/449

Update a local copy of the PR:
$ git checkout pull/449
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 449

View PR using the GUI difftool:
$ git pr show -t 449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/449.diff

Using Webrev

Link to Webrev Comment

…iagnostic option

8367722: [GenShen] ShenandoahEvacuationStats is always empty

Reviewed-by: ysr, phh
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 6, 2026

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367473: Shenandoah: Make the detailed evacuation metrics a runtime diagnostic option
8367722: [GenShen] ShenandoahEvacuationStats is always empty

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e4cb86df2b05cef6dd7e29e8803ebbbf5b4fe5a2 8367473: Shenandoah: Make the detailed evacuation metrics a runtime diagnostic option Apr 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 6, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 6, 2026

Webrevs

@earthling-amzn
Copy link
Copy Markdown
Author

/approval request This change converts a non-product only build time option into a runtime option. This option has provided very valuable performance debugging data from release builds. This change only affects Shenandoah code. We (Amazon) have enabled this option in production-like environments and we see no significant performance impact when the option is disabled.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@earthling-amzn
8367473: The approval request has been created successfully.
8367722: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant