8296653: ComboBox promptText is not displayed when the value is reset #1989
Conversation
|
👋 Welcome back zelmidaoui! A progress list of the required criteria for merging this PR into |
|
@Ziad-Mid This change is no longer ready for integration - check the PR body for details. |
Webrevs
|
arapte
left a comment
arapte
left a comment
There was a problem hiding this comment.
Manually tested the program attached to the bug. Change fixes the bug.
Can you please try for adding a test.
| if (empty) { | ||
| if (cell == null) return true; | ||
|
|
||
| // JDK-8296653 |
There was a problem hiding this comment.
We generally don't include the bug id. Please remove.
There was a problem hiding this comment.
May be we can add a comment to explain the change.
There was a problem hiding this comment.
I have updated the code could you please re review
|
I think a test would be good here. |
I have added one could you please re-review |
|
|
||
| @Test | ||
| public void testPromptTextRestoredAfterSetValueNull() { | ||
| comboBox.setPromptText("Select Value"); |
There was a problem hiding this comment.
I would suggest to have a String variable with "Select Value" as value. And then use it here and the other two occurrences
| SingleSelectionModel<String> sm = comboBox.getSelectionModel(); | ||
| sl = new StageLoader(comboBox); | ||
| comboBox.applyCss(); | ||
| comboBox.show(); |
There was a problem hiding this comment.
applyCss and show are not needed, should be removed
| // Select an item | ||
| sm.select(2); | ||
| Toolkit.getToolkit().firePulse(); | ||
|
|
There was a problem hiding this comment.
An assert that the buttonCell is not Select Value would make sense here (assertNotEquals)
|
|
||
| if (cell == buttonCell) { | ||
| final String promptText = comboBox.getPromptText(); | ||
| if (comboBox.getValue() == null |
There was a problem hiding this comment.
is the comboBox.getValue() check needed? Asking, as we are in here only if empty is true, so maybe this is not needed to check?
3 participants
The issue occurred because the skin marks the button cell as “empty” when the value becomes null.
With the fix clearing the ComboBox value re-shows the prompt text.
Tested using the code present in the bug.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1989/head:pull/1989$ git checkout pull/1989Update a local copy of the PR:
$ git checkout pull/1989$ git pull https://git.openjdk.org/jfx.git pull/1989/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1989View PR using the GUI difftool:
$ git pr show -t 1989Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1989.diff
Using Webrev
Link to Webrev Comment