-
Notifications
You must be signed in to change notification settings - Fork 199
8450: Improve usability of selectable action items by supporting keyboard and double-click interactions #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…oard and double-click interactions
|
👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into |
|
@aymane-harmaz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@aymane-harmaz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@aymane-harmaz The pull request is being re-evaluated and the inactivity timeout has been reset. |
thegreystone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
Thanks for the review /integrate |
|
@aymane-harmaz |
|
/sponsor |
|
Going to push as commit 916c7cf.
Your commit was automatically rebased without conflicts. |
|
@thegreystone @aymane-harmaz Pushed as commit 916c7cf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR adds more interaction capabilities to tree items and checkbox tables:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/682/head:pull/682$ git checkout pull/682Update a local copy of the PR:
$ git checkout pull/682$ git pull https://git.openjdk.org/jmc.git pull/682/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 682View PR using the GUI difftool:
$ git pr show -t 682Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/682.diff
Using Webrev
Link to Webrev Comment