Skip to content

Conversation

@aymane-harmaz
Copy link
Member

@aymane-harmaz aymane-harmaz commented Oct 29, 2025

This PR adds more interaction capabilities to tree items and checkbox tables:

  • Tree items: Added support for expanding/collapsing via double-click and Enter key press.
  • Checkbox table: Added support for enabling/disabling via Enter key press.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8450: Improve usability of selectable action items by supporting keyboard and double-click interactions (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/682/head:pull/682
$ git checkout pull/682

Update a local copy of the PR:
$ git checkout pull/682
$ git pull https://git.openjdk.org/jmc.git pull/682/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 682

View PR using the GUI difftool:
$ git pr show -t 682

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/682.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2025

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@aymane-harmaz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8450: Improve usability of selectable action items by supporting keyboard and double-click interactions

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 2c9ad54: 8470: Unresolved placeholders shown in JFR result overview's table mode
  • a781394: 8427: Text getting overlapped on graph of Processes screen
  • 1e4c82b: 8335: Duplicate values in tooltip for RSS and RSS (Peak) in memory tab

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title 8450: Improve usability of selectable action items by supporting keyb… 8450: Improve usability of selectable action items by supporting keyboard and double-click interactions Oct 29, 2025
@openjdk openjdk bot added the rfr label Oct 29, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2025

@aymane-harmaz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@aymane-harmaz
Copy link
Member Author

/keepalive

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@aymane-harmaz The pull request is being re-evaluated and the inactivity timeout has been reset.

Copy link
Member

@thegreystone thegreystone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@openjdk openjdk bot added the ready label Dec 2, 2025
@aymane-harmaz
Copy link
Member Author

Thanks for the review

/integrate

@openjdk openjdk bot added the sponsor label Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@aymane-harmaz
Your change (at version bb29cd5) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 3, 2025

Going to push as commit 916c7cf.
Since your change was applied there have been 5 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 3, 2025
@openjdk openjdk bot closed this Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@thegreystone @aymane-harmaz Pushed as commit 916c7cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants