Skip to content

8381608: [lworld] Remove vmTestbase/nsk/jdi/Accessible/modifiers/modifiers001/TestDescription.java from ProblemList-enable-preview.txt#2296

Closed
plummercj wants to merge 1 commit intoopenjdk:lworldfrom
plummercj:8381608_remove_pl
Closed

8381608: [lworld] Remove vmTestbase/nsk/jdi/Accessible/modifiers/modifiers001/TestDescription.java from ProblemList-enable-preview.txt#2296
plummercj wants to merge 1 commit intoopenjdk:lworldfrom
plummercj:8381608_remove_pl

Conversation

@plummercj
Copy link
Copy Markdown
Contributor

@plummercj plummercj commented Apr 3, 2026

The test no longer fails due to CODETOOLS-7904149 being fixed. It can be removed from the problem list.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8381608: [lworld] Remove vmTestbase/nsk/jdi/Accessible/modifiers/modifiers001/TestDescription.java from ProblemList-enable-preview.txt (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2296/head:pull/2296
$ git checkout pull/2296

Update a local copy of the PR:
$ git checkout pull/2296
$ git pull https://git.openjdk.org/valhalla.git pull/2296/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2296

View PR using the GUI difftool:
$ git pr show -t 2296

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2296.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 3, 2026

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 3, 2026

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381608: [lworld] Remove vmTestbase/nsk/jdi/Accessible/modifiers/modifiers001/TestDescription.java from ProblemList-enable-preview.txt

Reviewed-by: matsaave, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8381608 8381608: [lworld] Remove vmTestbase/nsk/jdi/Accessible/modifiers/modifiers001/TestDescription.java from ProblemList-enable-preview.txt Apr 3, 2026
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 3, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 3, 2026

Webrevs

Copy link
Copy Markdown
Contributor

@matias9927 matias9927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 6, 2026
@plummercj
Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

Going to push as commit de4e3f5.
Since your change was applied there have been 116 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 6, 2026
@openjdk openjdk bot closed this Apr 6, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@plummercj Pushed as commit de4e3f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants