8381608: [lworld] Remove vmTestbase/nsk/jdi/Accessible/modifiers/modifiers001/TestDescription.java from ProblemList-enable-preview.txt#2296
Conversation
|
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
|
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 116 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit de4e3f5.
Your commit was automatically rebased without conflicts. |
|
@plummercj Pushed as commit de4e3f5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The test no longer fails due to CODETOOLS-7904149 being fixed. It can be removed from the problem list.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2296/head:pull/2296$ git checkout pull/2296Update a local copy of the PR:
$ git checkout pull/2296$ git pull https://git.openjdk.org/valhalla.git pull/2296/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2296View PR using the GUI difftool:
$ git pr show -t 2296Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2296.diff
Using Webrev
Link to Webrev Comment