Skip to content

[type-classes] JDK-8377002: Prototype rational number support#2300

Closed
jddarcy wants to merge 2 commits intoopenjdk:type-classesfrom
jddarcy:JDK-8377002
Closed

[type-classes] JDK-8377002: Prototype rational number support#2300
jddarcy wants to merge 2 commits intoopenjdk:type-classesfrom
jddarcy:JDK-8377002

Conversation

@jddarcy
Copy link
Copy Markdown
Member

@jddarcy jddarcy commented Apr 6, 2026

Straightforward prototype of a rational number class backed by BigIntegers. A "small rational" class backed by int's will follow.


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2300/head:pull/2300
$ git checkout pull/2300

Update a local copy of the PR:
$ git checkout pull/2300
$ git pull https://git.openjdk.org/valhalla.git pull/2300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2300

View PR using the GUI difftool:
$ git pr show -t 2300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2300.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 6, 2026

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into type-classes will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

[type-classes] JDK-8377002: Prototype rational number support

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the type-classes branch:

  • 8de49a2: [type-classes] 8380667: Prototype FP8_E5M2
  • c4a6698: [type-classes] 8373068: Revisit details of Float16 to decimal conversion algorithm

Please see this link for an up-to-date comparison between the source branch of this pull request and the type-classes branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the type-classes branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 6, 2026

Webrevs

@jddarcy
Copy link
Copy Markdown
Member Author

jddarcy commented Apr 6, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

Going to push as commit e93e1c5.
Since your change was applied there have been 2 commits pushed to the type-classes branch:

  • 8de49a2: [type-classes] 8380667: Prototype FP8_E5M2
  • c4a6698: [type-classes] 8373068: Revisit details of Float16 to decimal conversion algorithm

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 6, 2026
@openjdk openjdk bot closed this Apr 6, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@jddarcy Pushed as commit e93e1c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant