[type-classes] JDK-8377002: Prototype rational number support#2300
[type-classes] JDK-8377002: Prototype rational number support#2300jddarcy wants to merge 2 commits intoopenjdk:type-classesfrom
Conversation
|
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
|
@jddarcy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit e93e1c5.
Your commit was automatically rebased without conflicts. |
Straightforward prototype of a rational number class backed by BigIntegers. A "small rational" class backed by int's will follow.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2300/head:pull/2300$ git checkout pull/2300Update a local copy of the PR:
$ git checkout pull/2300$ git pull https://git.openjdk.org/valhalla.git pull/2300/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2300View PR using the GUI difftool:
$ git pr show -t 2300Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2300.diff
Using Webrev
Link to Webrev Comment