HIE-5 Make the Patient Interceptor configurable explicitly#20
Open
suubi-joshua wants to merge 1 commit intoopenmrs:mainfrom
Open
HIE-5 Make the Patient Interceptor configurable explicitly#20suubi-joshua wants to merge 1 commit intoopenmrs:mainfrom
suubi-joshua wants to merge 1 commit intoopenmrs:mainfrom
Conversation
Author
|
@samuelmale is this something close to what you were thinking of? |
DeepakJain06
approved these changes
Apr 5, 2025
There was a problem hiding this comment.
The method isClientRegistryEventsEnabled() correctly checks if events are enabled, but should we also consider fetching this value from a global property instead of just relying on environment variables?"
🔹 "Instead of using Boolean.TRUE.equals(eventsEnabled), you could simply use Boolean.TRUE.equals(eventsEnabled) && StringUtils.isNotBlank(getClientRegistryServerUrl()) inline to improve readability."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue: https://openmrs.atlassian.net/browse/HIE-5
Added explicit configuration for Client Registry Events enablement:
Added new global property constant
GP_CLIENT_REGISTRY_EVENTS_ENABLEIntroduced
eventsEnabledconfiguration fieldEvents processing now requires both explicit enablement and valid server URL configuration
Improves configuration clarity and control over event-based functionality