RA-1589: Observations created with style="textarea" are not displayed with newlines.#185
Open
ATLCTO wants to merge 1 commit intoopenmrs:masterfrom
Open
RA-1589: Observations created with style="textarea" are not displayed with newlines.#185ATLCTO wants to merge 1 commit intoopenmrs:masterfrom
ATLCTO wants to merge 1 commit intoopenmrs:masterfrom
Conversation
isears
requested changes
May 23, 2019
Member
isears
left a comment
isears
left a comment
There was a problem hiding this comment.
Would it be possible to narrow down this change to a specific CSS class that would only affect the Observations elements, rather than all span/htmlform/p elements?
Member
|
@ATLCTO did you see the above comment? |
Member
|
@ATLCTO are you still working on this? |
Author
|
I looked into it when @isears made his first comment and it wasn’t possible to make it more specific as those elements were not decorated with a custom css. The other way to fix it was a code change (to replace “\n” with “ I can submit that change instead of the css change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observations created with style="textarea" are not displayed with newlines.
Add white-space: pre-wrap so that multi-line text observations are displayed with multiple lines (so they appear the same as they did in the textarea when they were created).