RA-1872:Add edit Privilege for Visit Dates and Visit Type on Visit Su…#383
Open
HerbertYiga wants to merge 1 commit intoopenmrs:masterfrom
Open
RA-1872:Add edit Privilege for Visit Dates and Visit Type on Visit Su…#383HerbertYiga wants to merge 1 commit intoopenmrs:masterfrom
HerbertYiga wants to merge 1 commit intoopenmrs:masterfrom
Conversation
Contributor
Author
|
@dkayiwa how does this look to you |
Member
|
The ticket reporter needs to have the first priority. |
Contributor
Author
Ok,i pinged him on the ticket ID @dkayiwa |
Contributor
Author
@dkayiwa the reporter has tested the changes and says every thing is fine as per his last comments on the ticket |
Contributor
Author
Contributor
Author
|
Hi @dkayiwa does this look good for merging? |
Contributor
Author
|
hi dan,i think we can actually go on to merge this and close the ticket since the reporter too tested the changes and found things working as expected cc @dkayiwa |
Contributor
Author
|
since GitHub actions bot now closes pull requests that have not been active after some time, trying to re-ping @dkayiwa @gracepotma to see whether this is now good for merging! |
dkayiwa
reviewed
Jan 27, 2022
| <a class="right" id="editVisitDatesLink" href="#" data-visit-id="[[= id]]">${ ui.message("coreapps.task.editVisitDate.label")}</a> | ||
| [[ if (canEditVisit) { ]] | ||
| <a class="right" id="editVisitDatesLink" href="#" data-visit-id="[[= id]]">${ ui.message("coreapps.task.editVisitDate.label")}</a> | ||
| [[ if (mutipleVisitType) { ]] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket Id:https://issues.openmrs.org/browse/RA-1872
Description
Added edit Privilege for Visit Dates and Visit Type on Visit Summary Dashboard