RA-1988 - When seething dates to midnight, change the required Global property from allowChangingVisitTime to allowConvertingTimezones#457
Open
icrc-toliveira wants to merge 1 commit intoopenmrs:masterfrom
Conversation
…lly correlated, the more apropiated global property for this use case seems to be GP_TIMEZONE_CONVERSIONS
|
@dkayiwa can you kindly review this? Apparently waiting for this PR is blocking ICRC. |
|
Also CCing @mogoodrich since I know you have dealt with a lot of timezone issues at PIH and you may be very interested in this. |
dkayiwa
reviewed
Nov 8, 2022
| HttpServletRequest request, UiUtils ui) { | ||
|
|
||
| boolean allowChangingVisitTime = BooleanUtils.toBoolean(Context.getAdministrationService().getGlobalProperty(CoreAppsConstants.GP_ALLOW_CHANGING_VISIT_TIME)); | ||
| boolean allowConvertingTimezones = BooleanUtils.toBoolean(Context.getAdministrationService().getGlobalProperty(UiFrameworkConstants.GP_TIMEZONE_CONVERSIONS)); |
Member
There was a problem hiding this comment.
@icrc-toliveira i find the name of GP_ALLOW_CHANGING_VISIT_TIME easier to understand than what you changed it to.
Secondly, do you mind explaining how just changing the used global property fixes the reported bug?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.openmrs.org/browse/RA-1988
Although changing time and changing timezone and intrinsically correlated, the more appropriated global property for this use case seems to be GP_TIMEZONE_CONVERSIONS.
Related PR's: