Improve VisitTypeHelper type safety and modernize usage#521
Open
Manas-Dikshit wants to merge 1 commit intoopenmrs:masterfrom
Open
Improve VisitTypeHelper type safety and modernize usage#521Manas-Dikshit wants to merge 1 commit intoopenmrs:masterfrom
Manas-Dikshit wants to merge 1 commit intoopenmrs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated Boolean(String) constructor in the patient header visit type flag with Boolean.parseBoolean.
Make JSON deserialization of the visit type ordering global property type-safe by deserializing into Map<String, String> instead of a raw HashMap.
Use the diamond operator and modern generic collection instantiation throughout VisitTypeHelper to reduce noise and remove unchecked warnings.
Details
showVisitTypeOnPatientHeaderSection now parses the global property via Boolean.parseBoolean, eliminating the deprecated boxed constructor and avoiding unnecessary allocation.
getOrderedVisitTypes now uses ObjectMapper.readValue with a TypeReference<Map<String, String>>, which aligns the map key type with the existing "1", "2", … index keys and removes the suspicious Map.get/unchecked conversion warnings.
Collection instantiations have been updated to use new ArrayList<>(), new HashMap<>(), and new LinkedHashMap<>() for clearer, more idiomatic Java.