HTML-777: Validate that encounter dates times are within visit start and end date.

[icrc-toliveira]

Background
The encounter date can be changed to be prior to the visit start date

Issue:
https://issues.openmrs.org/browse/HTML-777

Change:
Edit mode will now be validated

[HerbertYiga]

thanks @icrc-toliveira we can put this on the same line

[icrc-toliveira]

Hi @HerbertYiga
I´m not sure if this was you mean, but I change the indentation to be on the same line.
However, I noticed that if I let the project auto-ident, the entire file will have changes

[mks-d]

@icrc-toliveira please add appropriate unit tests for this.

[icrc-toliveira]

Hi @mks-d, @HerbertYiga

I just created the requested test,
If possible, could you have a look?

[dkayiwa]

@icrc-toliveira the new test passes even without your fix/changes

[icrc-toliveira]

@icrc-toliveira the new test passes even without your fix/changes

@dkayiwa Yes thx for noticing

Unfortunately I had mistyped the second request.
It had two times the value "w5" instead of one "w3" and one "w5".
Resulting always in at least one error message.

And since the test was validating the existence of error messages, the test would always pass

[dkayiwa]

@icrc-toliveira isn't this already covered by? https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/validator/EncounterValidator.java

[HerbertYiga]

isn't this already covered by? https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/validator/EncounterValidator.java

hi @icrc-toliveira,thanks too for also working on this,we will also need this could you kindly attend to @dkayiwa 's comments above

[HerbertYiga]

hi @icrc-toliveira trying to re ping you on this

[icrc-toliveira]

Hi @HerbertYiga, @dkayiwa

Will have a look

[HerbertYiga]

hi @dkayiwa does this look good enough to be merged now so that we release htmlformentryui?

[dkayiwa]

@HerbertYiga did you check the previous comments?

[HerbertYiga]

Will have a look

hi @icrc-toliveira do you still have some time to complete this so that we release htmlformentryui as soon as possible?

[icrc-toliveira]

Hi @HerbertYiga, @dkayiwa

I have been looking into the validation method mention by @dkayiwa, and yes indeed the Validation is called.
However, the exception is never handled, causing the FragmentFactory to throw and error and the form to be saved with the wrong date.

It is possible to handled the error, but the message that we get from it its far from perfect and not translatable.

Example on how to handle the exception:

try {
	// Do actual encounter creation/updating
	fes.applyActions();
}catch (ValidationException e) {
	validationErrors.add(new FormSubmissionError("general-form-error", e.getLocalizedMessage()));
	return returnHelper(validationErrors, fes, null);
}

[dkayiwa]

@icrc-toliveira are you able to reproduce this from here? https://qa-refapp.openmrs.org/

[HerbertYiga]

are you able to reproduce this from here? https://qa-refapp.openmrs.org/

hi @icrc-toliveira ,@dkayiwa left some comment for you!!

[icrc-toliveira]

Hi @dkayiwa @HerbertYiga
Currently I'm trying to replicate this using the https://qa-refapp.openmrs.org/

For now, I´m able to get the error but I´m unable to save the form.
Some further test is needed to be sure why I'm able to save it in our distro

[HerbertYiga]

Currently I'm trying to replicate this using the https://qa-refapp.openmrs.org/

For now, I´m able to get the error but I´m unable to save the form.
Some further test is needed to be sure why I'm able to save it in our distro

hi @dkayiwa could we be having any next steps here basing on these comments? cc @sherrif10

[dkayiwa]

@icrc-toliveira is still investigating.

[HerbertYiga]

hi @icrc-toliveira any progress on investigating this?

[icrc-toliveira]

hi @icrc-toliveira any progress on investigating this?

Hi @HerbertYiga

Not, much

I tried to replicate the forms causing the error in https://qa-refapp.openmrs.org/,
But for now, only was able to get the error message mentioned above.